Silence compiler warnings with Python 3.9
Starting with Python 3.9, the Python headers contain inline functions
that fall afoul of our -Wdeclaration-after-statement coding style. In
order to silence those warnings, I've added some GCC-specific
contortions to disable that warning for Python.h only. Clang doesn't
appear to warn about this at all; maybe it recognizes that this is an
external header file. We could also write a configure check for this if
we want to be more flexible.
(Attempts to convince upstream to change the coding style were
unsuccessful (https://bugs.python.org/issue39615).)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-Silence-compiler-warnings-with-Python-3.9.patchtext/plain; charset=UTF-8; name=0001-Silence-compiler-warnings-with-Python-3.9.patch; x-mac-creator=0; x-mac-type=0Download+19-1
On 2020-03-02 14:22, Peter Eisentraut wrote:
Starting with Python 3.9, the Python headers contain inline functions
that fall afoul of our -Wdeclaration-after-statement coding style. In
order to silence those warnings, I've added some GCC-specific
contortions to disable that warning for Python.h only. Clang doesn't
appear to warn about this at all; maybe it recognizes that this is an
external header file. We could also write a configure check for this if
we want to be more flexible.(Attempts to convince upstream to change the coding style were
unsuccessful (https://bugs.python.org/issue39615).)
My fix in cpython was accepted after all and the issue is no longer
present in the latest alpha (3.9.0a5), so this can be considered closed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services