model-writtenrun 8747 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane proposed symbolic alignment and storage constants to improve readability and searchability while working on ALTER TYPE; his initial patch deliberately left SQL literals unchanged because replacing them was not worth the complexity #1.
- Alvaro Herrera favored making tupmacs.h include the definitions directly but identified excessive dependencies in pg_type.h #2; Tom noted that this also exposed type OID macros and that the constants serve both pg_type and pg_attribute #3.
- Tom proposed including the smaller pg_type_d.h from tupmacs.h #4, Alvaro accepted that compromise #5, and Tom posted a polished revision needing only one additional include elsewhere #7.
- Michael Paquier checked the revised patch for missed conversion sites #8, and Tom committed it unchanged as 3ed2005ff5, confirming completion and thanking him for reviewing #9.
- After the commit, Andres Freund asked whether real enums could provide compiler checks for omitted cases #10; Tom explained that the underlying char storage could produce unwanted warnings without guaranteeing useful ones, leaving the macro conversion landed and no enum follow-up patch posted #11.