comments on elements of xlogctldata
Hi,
It seems the comments on SharedHotStandbyActive and
SharedRecoveryInProgress are the same in XLogCtlData.
How about modifying the comment on SharedHotStandbyActive?
Attached a patch.
Regards,
--
Torikoshi Atsushi
Attachments:
fix_comments_on_SharedHotStandbyActive_v1.patchapplication/octet-stream; name=fix_comments_on_SharedHotStandbyActive_v1.patchDownload
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 4fa446f..de2d4ee 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -649,8 +649,8 @@ typedef struct XLogCtlData
bool SharedRecoveryInProgress;
/*
- * SharedHotStandbyActive indicates if we're still in crash or archive
- * recovery. Protected by info_lck.
+ * SharedHotStandbyActive indicates if we allow hot standby queries to be
+ * run. Protected by info_lck.
*/
bool SharedHotStandbyActive;
On 2020/03/16 10:57, Atsushi Torikoshi wrote:
Hi,
It seems the comments on SharedHotStandbyActive and SharedRecoveryInProgress are the same in XLogCtlData.
How about modifying the comment on SharedHotStandbyActive?
Attached a patch.
Thanks for the report and patch!
The patch looks good to me.
I will commit it.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
On 2020/03/16 11:08, Fujii Masao wrote:
On 2020/03/16 10:57, Atsushi Torikoshi wrote:
Hi,
It seems the comments on SharedHotStandbyActive and SharedRecoveryInProgress are the same in XLogCtlData.
How about modifying the comment on SharedHotStandbyActive?
Attached a patch.
Thanks for the report and patch!
The patch looks good to me.
I will commit it.
Pushed! Thanks!
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters