pg_checksums in backend/storage/page/README

Started by Daniel Gustafssonalmost 6 years ago4 messages
#1Daniel Gustafsson
daniel@yesql.se
1 attachment(s)

I noticed in passing that backend/storage/page/README hadn't gotten the memo
about pg_checksums. The attached tiny diff adds a small mention of it.

cheers ./daniel

Attachments:

cksum_page_readme.diffapplication/octet-stream; name=cksum_page_readme.diff; x-unix-mode=0644Download
diff --git a/src/backend/storage/page/README b/src/backend/storage/page/README
index 5127d98da3..4e45bd92ab 100644
--- a/src/backend/storage/page/README
+++ b/src/backend/storage/page/README
@@ -9,7 +9,8 @@ have a very low measured incidence according to research on large server farms,
 http://www.cs.toronto.edu/~bianca/papers/sigmetrics09.pdf, discussed
 2010/12/22 on -hackers list.
 
-Current implementation requires this be enabled system-wide at initdb time.
+Current implementation requires this be enabled system-wide at initdb time, or
+by using the pg_checksums tool on an offline cluster.
 
 The checksum is not valid at all times on a data page!!
 The checksum is valid when the page leaves the shared pool and is checked
#2Magnus Hagander
magnus@hagander.net
In reply to: Daniel Gustafsson (#1)
Re: pg_checksums in backend/storage/page/README

On Thu, Mar 26, 2020 at 3:02 PM Daniel Gustafsson <daniel@yesql.se> wrote:

I noticed in passing that backend/storage/page/README hadn't gotten the memo
about pg_checksums. The attached tiny diff adds a small mention of it.

That seems obvious enough. Pushed, thanks!

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

#3Julien Rouhaud
rjuju123@gmail.com
In reply to: Daniel Gustafsson (#1)
Re: pg_checksums in backend/storage/page/README

On Thu, Mar 26, 2020 at 03:02:42PM +0100, Daniel Gustafsson wrote:

I noticed in passing that backend/storage/page/README hadn't gotten the memo
about pg_checksums. The attached tiny diff adds a small mention of it.

Good catch! LGTM

#4Michael Paquier
michael@paquier.xyz
In reply to: Magnus Hagander (#2)
Re: pg_checksums in backend/storage/page/README

On Thu, Mar 26, 2020 at 03:06:34PM +0100, Magnus Hagander wrote:

That seems obvious enough. Pushed, thanks!

Thanks for the fix.
--
Michael