model-writtenrun 8619 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andrew Dunstan proposed tightening Perl::Critic checks from severity 5 toward severity 3, while Robert Haas questioned whether the maintenance burden justified the benefits and Peter Eisentraut suggested assessing concrete patches #1 #2 #3.
- Noah Misch supported requiring warnings pragmas but opposed several stylistic restrictions as unnecessary for PostgreSQL's internal code; he also proposed dropping mandatory final returns, which Peter Eisentraut and Tom Lane supported #5 #6 #7.
- Andrew submitted four patches covering a severity-3 configuration with exceptions, consistent warnings pragmas, magic-variable cleanups, and miscellaneous changes to operators, loops, and statement separators #8.
- Mark Dilger challenged restrictions on mixed-precedence operators and comma-separated statements, while Tom Lane explored a narrower final-return check before concluding that maintaining custom Perl::Critic policies would be undesirable #9 #13 #11 #14.
- Noah reviewed the submitted code and selected the four idiomatic $/ changes as worthwhile standalone cleanups; he also recommended enforcing warnings pragmas at severity 5 instead of adopting the broader policy transition #17.
- David Steele shared pgBackRest's exception-based configuration experience, and Andrew narrowed his immediate goals to warnings pragmas, idiomatic $/ handling, and diagnostics identifying the violated policy #19 #20 #21.
- Andrew landed the warnings component with the revised severity-5 configuration as 7be5d8df1f and the four unchanged $/ hunks as 8f00d84afc, then announced completion of the noncontroversial work #22.
- Andrew accepted the consensus against further broad tightening and announced removal of the explicit-return requirement; 0516f94d18 implemented that discussion by removing its severity override #23.
- Andrew proposed applying stronger checks only to selected libraries, Alvaro Herrera encouraged an experiment, and Andrew submitted a reworked patch covering Catalog.pm, the test libraries, and MSVC modules with separate Perl::Critic runs #23 #24 #25.
- Noah rejected the library patch because separate style regimes and changes such as noncapturing regex groups offered insufficient benefit; Tom supported extra scrutiny when moving code into libraries but questioned whether the proposed checks supplied useful scrutiny #26 #28.
- The regex discussion exposed a separate correctness issue: Andrew proposed nongreedy comment matching, Garick Hamlin questioned whether greedy matching could erase intervening code, and Andrew confirmed that multiple comments on one line could trigger that problem #27 #29 #30.
- Alvaro supported fixing comment matching and using targeted critic annotations to document unusual Catalog.pm code, while Andrew favored handling the regex correction independently and reconsidering the complex Solution.pm expression; Mark supplied an inline extended-regex alternative #31 #32 #33.
- At the end of the thread, the selected cleanups and explicit-return policy removal had landed, but the library-only checking patch remained disputed and the regex improvements had no demonstrated landing; Noah reiterated that the proposed restrictions reduced code quality without sufficient benefit #34.