Sep 2023

1 commit
Remove the "snapshot too old" feature.
5 Sep 2023Thomas Munromaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: old_snapshot_threshold bottleneck on replica (modified before commit)Also in: snapshot too old issues, first around wraparound and then more. (not this thread)

Sep 2020

3 commits
Fix two bugs in MaintainOldSnapshotTimeMapping.
24 Sep 2020Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #253 of 3 reviewers saw the final version

The complete third patch in #25 matches the committed diff in src/backend/utils/time/snapmgr.c, including the corrected advance calculation and head_timestamp updates.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureIn #17, Thomas supplied tests exercising the mapping fixes from #1 and reported that they worked; 55b7e2f4d7 also explicitly credits his review.
  • Dilip Kumarsaw the final versionLLM analysis, 99% sureDilip assessed the fixes in #9 and examined multi-slot advancement test coverage in #18, with explicit review credit in 55b7e2f4d7.
  • Hamid Akhtarsaw the final versionLLM analysis, 100% sureHamid reported make installcheck-world passing in #27 after #25 and is explicitly credited as a reviewer in 55b7e2f4d7.
Add new 'old_snapshot' contrib module.
24 Sep 2020Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #253 of 3 reviewers saw the final version

The complete second patch in #25 matches the committed contrib/old_snapshot implementation and its three documentation changes. The proposed memcpy substitution was not incorporated.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas exercised the introspection function and showed its output in #5, with only light changes before landing and explicit review credit in aecf5ee2bb.
  • Dilip Kumarsaw the final versionLLM analysis, 100% sureDilip reviewed copying under OldSnapshotTimeMapLock in #9 and supplied a warning-free memcpy alternative in #16, and aecf5ee2bb explicitly credits his review.
  • Hamid Akhtarsaw the final versionLLM analysis, 100% sureHamid reported make installcheck-world passing in #27 after #25 and is explicitly credited as a reviewer in aecf5ee2bb.
Expose oldSnapshotControl definition via new header.
24 Sep 2020Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #253 of 3 reviewers saw the final version

The complete first patch in #25 matches the committed relocation of OldSnapshotControlData into src/include/utils/old_snapshot.h and export of oldSnapshotControl with PGDLLIMPORT.

  • Thomas Munrosaw the final versionLLM analysis, 99% sureThomas exercised the exposed oldSnapshotControl interface in #5, and f5ea92e8d6 explicitly credits his review.
  • Dilip Kumarsaw the final versionLLM analysis, 100% suref5ea92e8d6 explicitly credits Dilip as a reviewer, although his discussion in #9 does not isolate review of the header-export patch.
  • Hamid Akhtarsaw the final versionLLM analysis, 100% sureHamid reported make installcheck-world passing in #27 after #25 and is explicitly credited as a reviewer in f5ea92e8d6.

Credits across 4 commits

Author
Robert HaasLLM3
Thomas MunroLLM1
Reported by
Andres Freund1
Committer
Robert Haas3
Thomas Munro1

N LLM means N of the credits come from LLM analysis, not from commit trailers.