Participants
Fujii Masao
Fujii Masao
Masahiro Ikeda
Masahiro Ikeda
Michael Paquier
Michael Paquier
Laurenz Albe
Laurenz Albe
Tom Lane
Tom Lane
Attachments
Download Latest Patchset
+1-1
Show all attachments
Thread Outline
#1Masahiro IkedaMasahiro Ikeda
Apr 17, 2020
#2Fujii Masao↳Fujii Masaoto Masahiro Ikeda (#1)
Apr 17, 2020
#3...#4
Michael PaquierLaurenz Albe
↳▸to Fujii Masao (#2)
Apr 17, 2020
#3Michael Paquier↳Michael Paquierto Fujii Masao (#2)
Apr 17, 2020
#4Laurenz Albe↳Laurenz Albeto Michael Paquier (#3)
Apr 17, 2020
#5...#7
Tom LaneFujii Masao
↳▸to Fujii Masao (#2)
Apr 17, 2020
#5Tom Lane↳Tom Laneto Fujii Masao (#2)
Apr 17, 2020
#6Fujii Masao↳Fujii Masaoto Tom Lane (#5)
Apr 20, 2020
#7Fujii Masao↳Fujii Masaoto Fujii Masao (#6)
Apr 21, 2020
#8...#11
Masahiro IkedaFujii Masao
↳▸to Masahiro Ikeda (#1)
Jul 07, 2020
#8Masahiro Ikeda↳Masahiro Ikedato Masahiro Ikeda (#1)
Jul 07, 2020
#9Fujii Masao↳Fujii Masaoto Masahiro Ikeda (#8)
Jul 07, 2020
#10Masahiro Ikeda↳Masahiro Ikedato Fujii Masao (#9)
Jul 07, 2020
#11Fujii Masao↳Fujii Masaoto Masahiro Ikeda (#10)
Jul 08, 2020

It is not documented that pg_promote can exit standby mode

Started by Masahiro Ikedaalmost 6 years ago11 messageshackers
Jump to latest
#1Masahiro Ikeda
Masahiro Ikeda
ikedamsh@oss.nttdata.com

Hi, 

The document(high-availability.sgml) says that there are only two ways
to exit standby mode.

　26.2.2. Standby Server Operation
　Standby mode is exited and the server switches to normal operation when
pg_ctl promote is run or a trigger file is found (promote_trigger_file).

But there is another way, by calling pg_promote function.
I think we need to document it, doesn't it?

I attached a patch. Please review and let me know your thoughts.

Regards,
Masahiro Ikeda

Attachments:

0001-fix-doc-about-the-way-to-exit-standby-mode.patchtext/x-diff; name=0001-fix-doc-about-the-way-to-exit-standby-mode.patchDownload+2-3
#2Fujii Masao
Fujii Masao
masao.fujii@gmail.com
In reply to: Masahiro Ikeda (#1)
Re: It is not documented that pg_promote can exit standby mode

On 2020/04/17 13:11, ikedamsh wrote:

Hi,

The document(high-availability.sgml) says that there are only two ways to exit standby mode.

　26.2.2. Standby Server Operation
　Standby mode is exited and the server switches to normal operation when pg_ctl promote is run or a trigger file is found (promote_trigger_file).

But there is another way, by calling pg_promote function.
I think we need to document it, doesn't it?

I attached a patch. Please review and let me know your thoughts.

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#3Michael Paquier
Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#2)
Re: It is not documented that pg_promote can exit standby mode

On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote:

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

+1.
--
Michael
#4Laurenz Albe
Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Michael Paquier (#3)
Re: It is not documented that pg_promote can exit standby mode

On Fri, 2020-04-17 at 13:54 +0900, Michael Paquier wrote:

On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote:

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

+1.

+1. That was my omission in the original patch.

Yours,
Laurenz Albe

#5Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fujii Masao (#2)
Re: It is not documented that pg_promote can exit standby mode

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

It might be worth writing "<function>pg_promote()</function> is called"
(adding parentheses) to make it clearer that a function is being
referred to. No objection otherwise.

regards, tom lane

#6Fujii Masao
Fujii Masao
masao.fujii@gmail.com
In reply to: Tom Lane (#5)
Re: It is not documented that pg_promote can exit standby mode

On 2020/04/18 2:46, Tom Lane wrote:

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

It might be worth writing "<function>pg_promote()</function> is called"
(adding parentheses) to make it clearer that a function is being
referred to. No objection otherwise.

Yes. Also Masahiro-san reported me, off-list, that there are other places
where pg_promote is mentioned without parentheses. I think it's better to
add parentheses there. Attached is the updated version of the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:

0001-fix-doc-about-the-way-to-exit-standby-mode_v2.patchtext/plain; charset=UTF-8; name=0001-fix-doc-about-the-way-to-exit-standby-mode_v2.patch; x-mac-creator=0; x-mac-type=0Download+5-4
#7Fujii Masao
Fujii Masao
masao.fujii@gmail.com
In reply to: Fujii Masao (#6)
Re: It is not documented that pg_promote can exit standby mode

On 2020/04/20 20:38, Fujii Masao wrote:

On 2020/04/18 2:46, Tom Lane wrote:

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

Thanks for the report and the patch! It looks good to me.
Barring any objection, I will commit this patch.

It might be worth writing "<function>pg_promote()</function> is called"
(adding parentheses) to make it clearer that a function is being
referred to.  No objection otherwise.

Yes. Also Masahiro-san reported me, off-list, that there are other places
where pg_promote is mentioned without parentheses. I think it's better to
add parentheses there. Attached is the updated version of the patch.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#8Masahiro Ikeda
Masahiro Ikeda
ikedamsh@oss.nttdata.com
In reply to: Masahiro Ikeda (#1)
change a function name in a comment correctly

Hi,

There is the comment which related function name is not same.
I attached the patch to fix it. Please review.

Regards,

--
Masahiro Ikeda
NTT DATA CORPORATION

Attachments:

change_a_function_name_in_comment_correctly.patchtext/x-diff; name=change_a_function_name_in_comment_correctly.patchDownload+1-1
#9Fujii Masao
Fujii Masao
masao.fujii@gmail.com
In reply to: Masahiro Ikeda (#8)
Re: change a function name in a comment correctly

On 2020/07/07 11:50, Masahiro Ikeda wrote:

Hi,

There is the comment which related function name is not same.
I attached the patch to fix it. Please review.

Thanks for the report and patch! LGTM.
I will commit this later.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#10Masahiro Ikeda
Masahiro Ikeda
ikedamsh@oss.nttdata.com
In reply to: Fujii Masao (#9)
Re: change a function name in a comment correctly

There is the comment which related function name is not same.
I attached the patch to fix it. Please review.

Thanks for the report and patch! LGTM.
I will commit this later.

Thanks for checking.

Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION

#11Fujii Masao
Fujii Masao
masao.fujii@gmail.com
In reply to: Masahiro Ikeda (#10)
Re: change a function name in a comment correctly

On 2020/07/08 8:12, Masahiro Ikeda wrote:

There is the comment which related function name is not same.
I attached the patch to fix it. Please review.

Thanks for the report and patch! LGTM.
I will commit this later.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

← Back to Topics