Mar 2021

2 commits
Add pg_amcheck, a CLI for contrib/amcheck.
12 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: pg_amcheck contrib application (modified before commit)
Refactor and generalize the ParallelSlot machinery.
11 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: pg_amcheck contrib application (part of a posted patchset)

Feb 2021

3 commits
Generalize parallel slot result handling.
5 Feb 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #2071 of 1 reviewer saw the final version

Takes the slot-result-handler component of #207, changing the callback return type from PGresult * to bool and revising callback invocation, assertions, and comments. Robert describes these edits in #209.

  • Robert Haassaw the final versioncommittercommitted the patch
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
5 Feb 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2071 of 1 reviewer saw the final version

Matches the frontend-code relocation component of #207, moving connection, query, option, and parallel-slot helpers into src/fe_utils. Differences are MSVC line wrapping and omission of a typedefs.list entry.

  • Robert Haassaw the final versioncommittercommitted the patch
Factor pattern-construction logic out of processSQLNamePattern.
3 Feb 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2051 of 1 reviewer saw the final version

Exactly matches the patternToSQLRegex extraction in the first component of #205, including all 264 added and removed lines. The remaining four components were not included in this commit.

  • Robert Haassaw the final versioncommittercommitted the patch

Oct 2020

5 commits
Doc: clean up verify_heapam() documentation.
28 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Tom Lane's proposal in #182 to remove overwide example output led to this unattached documentation cleanup. The commit also corrects verify_heapam's documented signature and relocates general guidance in doc/src/sgml/amcheck.sgml.

Fix more portability issues in new amcheck code.
23 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #1711 of 1 reviewer saw the final version

Uses Mark's line-pointer sanity checks and regression expansion from #171. Tom moves minimum-length validation before tuple access, adjusts attnum initialization/reset, and changes corruption patterns to exercise checks on both endiannesses, as explained in #173.

  • Tom Lanesaw the final versioncommittercommitted the patch
Fix portability issues in new amcheck test.
23 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Comes from Mark Dilger's corrected WIP test attachment in #165, which is absent from the indexed patchsets. Tom confirms testing and committing it with whitespace/perltidy adjustments in #167; it replaces broad corruption with portable line-pointer patterns and diagnostic matching.

Try to avoid a compiler warning about using fxid uninitialized.
22 Oct 2020Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1391 of 1 reviewer saw the final version

Takes the first corrective patch from #139, restructuring get_xid_status to avoid using fxid uninitialized, with stray semicolons removed. The accompanying Perl-test repair was not committed in this change.

  • Robert Haassaw the final versioncommittercommitted the patch
Extend amcheck to check heap pages.
22 Oct 2020Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1323 of 8 reviewers saw the final version

The changed lines exactly match the first component of #132, adding verify_heapam, its SQL interface, documentation, and basic tests. The CLI, nonthrowing CLOG work, and additional ACL checks remain outside this commit.

  • Peter Geoghegansaw an earlier versionLLM analysis, 100% sureReviewed the initial integration and later found the raw-xmax/MultiXactId error and inappropriate cstring interface in #115, with substantive revisions following.
  • Andres Freundsaw an earlier versionLLM analysis, 100% sureDetailed review in #8 drove the SRF, visibility, locking, and helper redesign, followed by further transaction-horizon discussion in #77.
  • Álvaro Herrerasaw the final versionLLM analysis, 99% sureRequested separation of heap checking and the CLI in #53 and reviewed unsupported translation machinery in #127, after which only light heap changes followed.
  • Michael Paquiersaw an earlier versionLLM analysis, 96% sureExamined corruption-test coverage in #59 and is explicitly credited as a reviewer by 866e24d47d, with substantial checker revisions following.
  • Amul Sulsaw an earlier versionLLM analysis, 100% sureReviews including #64, #97, and #100 identified cleanup, TOAST, argument-default, warning, and schema issues corrected before later logic revisions.
  • Dilip Kumarsaw an earlier versionLLM analysis, 99% sureReviews in #41, #48, #51, and #56 produced hint-bit checks, redirect validation, and TOAST and cleanup corrections.
  • Tom Lanesaw the final versionLLM analysis, 99% sureObjected to the SQL cstring interface in #117 and proposed removing unsupported translation calls in #129, which the final submission adopted.
  • Robert Haassaw the final versioncommittercommitted the patch

Credits across 10 commits

Author
Mark DilgerLLM8
Reviewer
Robert Haascommitter7
Tom Lanecommitter1
Committer
Robert Haas7
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.