[PATCH] Fix Null pointer dereferences (pgoutput.c)

Started by Ranier Vilelaalmost 6 years ago2 messageshackers
Jump to latest
#1Ranier Vilela
ranier.vf@gmail.com

Hi,

Per Coverity.

If test oldtuple can be NULL, I mean it can really be NULL.
On DELETE process, if oldtuple is NULL, log error and continue.
So UPDATE must have the same treatment.

regards,
Ranier Vilela

Attachments:

fix_null_pointer_dereference_pgoutput.patchapplication/octet-stream; name=fix_null_pointer_dereference_pgoutput.patchDownload+5-3
#2Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Ranier Vilela (#1)
Re: [PATCH] Fix Null pointer dereferences (pgoutput.c)

On Thu, Apr 23, 2020 at 10:48 PM Ranier Vilela <ranier.vf@gmail.com> wrote:

Hi,

Per Coverity.

If test oldtuple can be NULL, I mean it can really be NULL.
On DELETE process, if oldtuple is NULL, log error and continue.
So UPDATE must have the same treatment.

I think I too had noticed this when working on my patch to move this
code to a different location in that function, posted here:
/messages/by-id/CA+HiwqEeU19iQgjN6HF1HTPU0L5+JxyS5CmxaOVGNXBAfUY06Q@mail.gmail.com

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com