Jul 2020

2 commits
Add nbtree Valgrind buffer lock checks.
21 Jul 2020Peter Geogheganmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #41 of 2 reviewers saw the final version

Commits the nbtree component of #4, preserving its wrapper implementations and call-site conversions. Changes are comments and whitespace, including correction of the _bt_checkpage() guidance identified in #6 and additional documentation in bufmgr.c and pg_config_manual.h.

  • Anastasia Lubennikovasaw the final versiontrailerIdentified incorrect _bt_conditionallockbuf() caller guidance in #6, which was corrected before committing with only light changes.
  • Georgios Kokolatossaw an earlier versiontrailerReviewed the instrumentation design and comments in #5, apparently using the original series because he discussed its removed bugfixes and could not see the latest version; subsequent revisions expanded defined-memory checks to local buffers.
Add Valgrind buffer access instrumentation.
18 Jul 2020Peter Geogheganmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: postpone next week's release
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #41 of 1 reviewer saw the final version

Commits the buffer-pin component of #4 with identical bufmgr.c changes and added USE_VALGRIND documentation in src/include/pg_config_manual.h. Its credited co-author Álvaro Herrera supplied the original patch discussed in #1, but did not post here; this thread's matching submission is newer than the 2015 source in thread #32933.

  • Anastasia Lubennikovasaw the final versiontrailerReviewed the two-patch series and marked it ready for committer in #6; the buffer-pin component subsequently received only documentation changes.

Apr 2020

2 commits
Fix another minor page deletion buffer lock issue.
25 Apr 2020Peter Geogheganmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #1

Takes the third patch from #1, reading BTreeTupleGetTopParent(leafhikey) before releasing the leaf lock in _bt_unlink_halfdead_page(). The committed version additionally reorganizes the target-selection branches, uses BlockNumberIsValid(), adds a target-level assertion, and expands comments.

Fix minor nbtree page deletion buffer lock issue.
25 Apr 2020Peter Geogheganmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1

Takes the fourth patch from #1, replacing !P_LEFTMOST(opaque) with leftsib != P_NONE in _bt_pagedel(). The only additional changes clarify descent-stack reuse and right-sibling comments in src/backend/access/nbtree/nbtpage.c.

Credits across 4 commits

Author
Peter Geoghegan2 LLM4
Alvaro Herrera1
Reviewer
Anastasia Lubennikova2
Georgios Kokolatos1
Committer
Peter Geoghegan4

N LLM means N of the credits come from LLM analysis, not from commit trailers.