Accidental use of the PVC_RECURSE_WINDOWFUNCS flag?
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t42307psql -h localhost -U postgresBuilt from patchset v1 (message #1), August 24, 2026 at 11:54 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t42307_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t42307_1 && git checkout t42307_1Patchset v1 (message #1) is on t42307_1
I think that the PVC_RECURSE_WINDOWFUNCS flag shouldn't be used in
make_partial_grouping_target().
First, this function uses the grouping_target (see grouping_planner()) as the
input, and that should only contain the input expressions of window functions
as opposed to the window functions themselves. (make_window_input_target() is
responsible for pulling the input expressions from the window functions.)
Second, if a window function appeared in the result of
make_partial_grouping_target() for any reason, the Agg node would fail to
evaluate it. Am I wrong?
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Antonin Houska <ah@cybertec.at> wrote:
Second, if a window function appeared in the result of
make_partial_grouping_target() for any reason, the Agg node would fail to
evaluate it. Am I wrong?
Well, this is PVC_RECURSE..., not PVC_INCLUDE..., so the window function
cannot appear in the result. But I still think that the function shouldn't
find any window functions.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com