Fix a typo in slot.c

Started by Masahiko Sawadaover 5 years ago5 messages

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

1 attachment(s)

Hi,

I've attached the patch for $subject. The old comment seems to be
borrowed from WalSndShmemInit().

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

fix_typo.patchapplication/octet-stream; name=fix_typo.patchDownload

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index d3d1033beb..006b2da1c3 100644
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -126,7 +126,7 @@ ReplicationSlotsShmemSize(void)
 }
 
 /*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize replication slots' shared memory.
  */
 void
 ReplicationSlotsShmemInit(void)

Amit Kapila

amit.kapila16@gmail.com

over 5 years ago

In reply to: Masahiko Sawada (#1)

Re: Fix a typo in slot.c

On Fri, May 15, 2020 at 9:16 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:

Hi,

I've attached the patch for $subject. The old comment seems to be
borrowed from WalSndShmemInit().

 /*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize replication slots' shared memory.
  */

How about changing it to "Allocate and initialize shared memory for
replication slots"?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

In reply to: Amit Kapila (#2)

1 attachment(s)

Re: Fix a typo in slot.c

On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote:

On Fri, May 15, 2020 at 9:16 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:

Hi,

I've attached the patch for $subject. The old comment seems to be
borrowed from WalSndShmemInit().
/*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize replication slots' shared memory.
*/
How about changing it to "Allocate and initialize shared memory for
replication slots"?

Agreed.

Attached the updated patch.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

fix_typo_v2.patchapplication/octet-stream; name=fix_typo_v2.patchDownload

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index d3d1033beb..c8bb6e4f37 100644
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -126,7 +126,7 @@ ReplicationSlotsShmemSize(void)
 }
 
 /*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize shared memory for replication slots.
  */
 void
 ReplicationSlotsShmemInit(void)

Amit Kapila

amit.kapila16@gmail.com

over 5 years ago

In reply to: Masahiko Sawada (#3)

Re: Fix a typo in slot.c

On Fri, May 15, 2020 at 10:08 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:

On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote:
/*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize replication slots' shared memory.
*/
How about changing it to "Allocate and initialize shared memory for
replication slots"?
Agreed.

Attached the updated patch.

Pushed.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

In reply to: Amit Kapila (#4)

Re: Fix a typo in slot.c

On Mon, 18 May 2020 at 13:59, Amit Kapila <amit.kapila16@gmail.com> wrote:

On Fri, May 15, 2020 at 10:08 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote:
/*
- * Allocate and initialize walsender-related shared memory.
+ * Allocate and initialize replication slots' shared memory.
*/
How about changing it to "Allocate and initialize shared memory for
replication slots"?
Agreed.

Attached the updated patch.
Pushed.

Thank you!

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services