Mar - Apr 2021

3 commits
Tweak behavior of pg_dump --extension with configuration tables
15 Apr 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #351 of 1 reviewer saw the final version

The pg_dump.c and documentation changes match #35 exactly; only test comments and the rename from without_extension_implicit_schema to without_extension_internal_schema differ, following #36 and confirmed in #37.

  • Noah Mischsaw the final versiontrailerReviewed the fix and requested a more descriptive test name in #36, which Michael adopted before committing.
Remove duplicated --no-sync switches in new tests of test_pg_dump
13 Apr 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Removes two duplicated --no-sync arguments from src/test/modules/test_pg_dump/t/001_base.pl, addressing the TODO in Noah's attachment at #30; no attached patch contains these deletions, and Michael acknowledges the report in #35.

Add support for --extension in pg_dump
31 Mar 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #273 of 4 reviewers saw the final version

All changed lines in pg_dump.c, test_pg_dump/t/001_base.pl, and pg_dump.sgml match #27 modulo rebase; the commit credits Guillaume Lelarge, whose implementation Michael revised and submitted.

  • David Fettersaw the final versiontrailerCorrected the documentation's 'Multiple schemas' wording in #20, with only light implementation cleanup, documentation, and test changes following.
  • Tom Laneno review foundtrailerEstablished the intended option semantics in #6 and #16, but explicitly said he had not read the patch and showed no patch inspection or testing.
  • Michael Paquiersaw the final versiontrailerIdentified documentation and test issues in #15, supplied the revised patch in #27, and confirmed his final check and application in #28.
  • Asif Rehmansaw the final versiontrailerReported successful feature and installcheck-world testing in #12 and questioned schema exclusion behavior, with only light cleanup, documentation, and test changes following.

Credits across 3 commits

Author
Guillaume Lelarge1
Michael PaquierLLM1
Reviewer
Asif Rehman1
David Fetter1
Michael Paquier1
Noah Misch1
Tom Lane1
Reported by
Noah Misch2
Committer
Michael Paquier3

N LLM means N of the credits come from LLM analysis, not from commit trailers.