model-writtenrun 7734 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut introduced SEARCH and CYCLE clauses in #1, implementing the SQL-standard transformations in the rewriter to provide recursive-query ordering and cycle detection without new execution machinery.
- Vik Fearing tested the initial patch in #3 and #6, finding failures involving TABLE/star expansion and references to another CTE, questioning cycle-mark restrictions, and proposing optional Boolean cycle marks.
- Peter explained cycle termination and NULL behavior in #4 and #7, while Pavel Stehule and Vik questioned parse-time restrictions on cycle marks in #5 and #6; no general expression support was settled.
- Peter's revision #8 fixed the CTE-reference and star-expansion problems by excluding generated columns from expansion inside the CTE, while explicitly leaving the accepted cycle-mark expressions unchanged.
- Peter separated a preparatory patch in #9 to put the cycle flag before the path in existing examples and tests, making them consistent with the planned standard syntax.
- Pavel's testing in #10 and #11 exposed a UNION DISTINCT crash and a failure when querying a view containing a CYCLE clause.
- Peter addressed those failures in #12, moved the rewriting code into rewriteSearchCycle.c, and temporarily rejected UNION DISTINCT because record hashing was unavailable; he deferred optional USING paths because the path remained necessary for internal bookkeeping.
- Pavel argued for eventual UNION DISTINCT support in #13 and reported successful check-world and documentation builds in #14, marking the patch ready for a committer.
- The independent example-and-test adjustment from #9 landed unchanged as 3fb676504d.
- Robert Haas cautioned in #15 against expression evaluation in the raw parser and highlighted catalog-access, plan-cache, and security concerns for any broader cycle-mark expression support.
- The manual recursive-query documentation from #12 landed separately as 323ae003e4, with subsection headings, search-order examples, and small editorial adjustments, leaving the new syntax for the main feature commit.
- Peter's updated patch #17 enabled UNION DISTINCT after record hashing became available, added dependency tracking and stronger parse-time checks, and rejected unsupported nested UNION shapes instead of crashing; Pavel verified its tests and documentation in #18.
- Vik reconsidered his earlier star-expansion preference in #19 and suggested a separate hidden-column feature in #20, but the committed implementation retained the expansion behavior from the revised patch.
- The main feature landed from #17 as 3696a600e2, with only an error-test substitution from XML to point, and Peter announced completion in #21.
- After the SQL:202x draft adopted optional Boolean cycle marks, Peter posted the enhancement in #23; Vik reviewed it and supplied the missing T133 feature entry in #24, and Peter requested a draft-standard annotation in #25.
- The enhancement and feature-table fix landed together as f4adc41c4f, with the requested annotation, and Peter confirmed completion in #27; the submitted work was complete, while optional USING paths and broader nested-UNION support remained deferred.