Jun 2020

2 commits
Bump catversion for ACL changes on replication origin functions
15 Jun 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Only changes CATALOG_VERSION_NO in src/include/catalog/catversion.h, which no attached patch changes. Tom Lane requested the missing bump in #27, and Michael Paquier acknowledged the fix in #28.

  • Tom Lanesaw an earlier versionLLM analysis, 92% sureReported the missing catalog-version bump in the committed form of #19 at #27, directly prompting this fix; his review predates the distinct monitoring-grant remainder #31.
Replace superuser check by ACLs for replication origin functions
14 Jun 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #193 of 3 reviewers saw the final version

The origin.c, system_views.sql, and func.sgml changes match #19; the commit additionally adds permission-denial regression coverage in contrib/test_decoding/sql/replorigin.sql and its expected output. Although Michael Paquier sent the source patchset, the commit explicitly credits Martín Marqués, whose series appears in #15.

  • Kyotaro Horiguchisaw the final versiontrailerReviewed ACL completeness and grants, supplied the documentation fix in #17, and explicitly approved the narrowed final patch in #24.
  • Michael Paquiersaw the final versiontrailerProposed ACLs in #3, requested separation of grants in #7, prepared the narrowed patch in #19, and committed the final version as confirmed in #26.
  • Masahiko Sawadasaw the final versiontrailerQuestioned view-access semantics and spotted a typo in #16, then accepted the narrowed ACL change in #22 after discussing the need for both SELECT and EXECUTE grants.

Credits across 2 commits

Author
Martín Marqués1
Reviewer
Kyotaro Horiguchi1
Masahiko Sawada1
Michael Paquier1
Reported by
Tom Lane1
Committer
Michael Paquier2