Nov 2023

2 commits
Fix array subscript warnings
30 Nov 2023Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: pgsql: Read include/exclude commands for dump/restore from file (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #2052 of 2 reviewers saw the final version

The added and removed lines exactly match #205: seven unsigned-char casts at isalpha/isspace call sites in src/bin/pg_dump/filter.c.

  • Tom Lanesaw the final versionLLM analysis, 96% sureIn #204, Tom identified the signed-char undefined behavior in the landed version of #200, prompting the light corrective patch #205.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch
Read include/exclude commands for dump/restore from file
29 Nov 2023Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #2001 of 7 reviewers saw the final version

The commit matches #200 with light header, diagnostic, formatting, and typedef-list cleanup plus a pg_dumpall --globals-only exclusion test, confirmed in #202. Although Daniel sent the source patchset, the commit explicitly credits Pavel Stehule as its author.

  • Justin Pryzbysaw an earlier versiontrailerJustin supplied extensive parser, documentation, portability, translation, and test feedback through #185 and #188, before the later error-handling and command-enum revisions.
  • vignesh Csaw an earlier versiontrailerVignesh reviewed file closing, line endings, allocation constants, help text, and comment documentation in #15, #23, #28, and #35, before substantial redesign.
  • Dean Rasheedsaw an earlier versiontrailerDean challenged the restricted syntax and requested shared option processing and nested files in #60 and #64, before the eventual return to object filters.
  • Tomas Vondrasaw an earlier versiontrailerTomas reviewed the options-file approach in #75 and filter-combination semantics in #114, before shared-tool support and subsequent parser revisions.
  • Julien Rouhaudsaw an earlier versiontrailerJulien reviewed grammar naming, quoted qualified identifiers, diagnostics, pattern normalization, and tests from #136 through #182, before new filter types and the final error-handling refactor.
  • Erik Rijkerssaw an earlier versiontrailerErik tested earlier versions and reported documentation, lexer-output, and dump/restore compatibility issues in #119, #124, #134, and #143, while #201 confirms principally earlier testing.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Pavel Stehule2
Reviewer
Daniel Gustafssoncommitter2
Dean Rasheed1
Erik Rijkers1
Julien Rouhaud1
Justin Pryzby1
Tomas Vondra1
vignesh C1
Reported by
Michael Paquier1
Tom Lane1
Committer
Daniel Gustafsson2