model-writtenrun 3796 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
May - Sep 2020 · 7 entries
- Pavel Stehule proposed reading table names from a file because a customer's generated table selection exceeded command-line limits, supplying the first implementation in #1 and explaining the OLAP use case in #3.
- David Fetter, Tom Lane, and Justin Pryzby encouraged broader inclusion and exclusion support in #4, #5, and #7, leading Pavel to add several object-specific file options in #8.
- Justin proposed a unified filter format in #9, and Pavel replaced the separate switches with --filter and symbolic include/exclude commands in #10.
- Justin and vignesh C reviewed validation, whitespace, stream cleanup, comments, and documentation, leading to parser extraction and successive corrections through #25, followed by Justin's supplied fixes in #32 and their integration in #33.
- Daniel Gustafsson raised structured-format and extensibility concerns in #26 and #30, while Pavel and Justin defended a simple text format suitable for generated pipelines in #27 and #29.
- The implementation adopted shared line-reading helpers and reusable buffers in #43 and #44, then gained TAP tests and corrected blank-line handling in #47.
- Surafel Temesgen requested tests and pg_dumpall support in #45, but Pavel initially kept pg_dumpall outside the patch's scope in #46.
Nov 2020 · 3 entries
- Stephen Frost challenged the restricted syntax and handling of unusual identifiers in #49, and Justin supplied an experimental generic configuration implementation in #56, while Pavel separately repaired multiline and doubled-quote handling in #58 and #59.
- Dean Rasheed requested shared command-line option processing, multiple files, and nesting in #60, and Pavel replaced the limited filter design with --options-file in #68.
- Justin supplied quoting fixes and recursive-file support in #70; Pavel incorporated selected fixes and implemented two-pass command-line precedence, cycle avoidance, and escaping in #71.
Jul 2021 · 2 entries
- The options-file branch continued through months of rebases ending at #91, but Tomas Vondra argued for a separate, simple object-filter facility in #75, and Tom Lane proposed readable include/exclude keywords in #79.
- Pavel revived the earlier filter implementation with keyword syntax in #92, leaving generic configuration-file support outside the eventual feature; Daniel described the compromise of separate filters and possible future structured configuration in #98.
Sep - Oct 2021 · 1 entry
- September and October review refined scanning, multiline names, doubled quotes, keyword matching, documentation, strict-name tests, and buffer lifetime through #95, #110, #116, #122, and #125.
Jul - Nov 2022 · 9 entries
- After another maintenance rebase, Andrew Dunstan requested pg_dumpall support in #127, and Pavel moved the parser into shared filter.c/filter.h while adding pg_dumpall and pg_restore support in #129.
- Justin's review in #130 exposed cross-tool integration problems, prompting caller-managed error handling in #131 and expanded dumpall/restore tests in #132.
- Daniel replaced the handwritten parser with Flex/Bison in #133, then corrected lexer whitespace after Erik Rijkers's report in #134 and revised grammar naming following Julien Rouhaud's feedback in #136.
- John Naylor reported grammar conflicts in #139, Andrew questioned the generated parser's complexity in #140, and Daniel removed the redundant production in #141.
- Andres Freund added Meson support and repaired its target and Windows generation rules across #148, #149, and #150, but disagreement about parser complexity persisted.
- Pavel returned directly to the handwritten branch with Meson support and clearer tool-specific wrapper names in #156; Daniel later explained in #181 that he had stepped back because his preferred generated-parser approach lacked support.
- Julien found failures for quoted qualified identifiers in #160, leading to parser corrections in #161 and clearer table_data naming and diagnostics in #163.
- Justin caught an incorrect trigger argument in #165, and broader restore tests led Pavel to replace identifier parsing with whitespace-normalized pattern parsing for function signatures in #169, while existing pg_restore limitations remained outside this patch.
- After Julien's further review and comment improvements, Andres reported an AddressSanitizer buffer overrun in #177, which Pavel fixed together with a per-filter memory leak in #179.
Mar 2023 · 2 entries
- Following another gap, Pavel added table-and-children filtering in #183; Justin supplied corrections and an experimental shared filtering function in #185, but Pavel preferred the simpler existing interfaces in #186 and incorporated only the selected fixes in #187.
- Justin pointed out missing extension support in #188, which Pavel added in #190, followed months later by a rebase and fixes for its option number and missing switch break in #191, #192, and #193.
Nov 2023 · 5 entries
- Daniel resumed work in #194, accepted the handwritten parser, and simplified error reporting and application-specific exits using a callback and explicit token switches.
- Pavel corrected format annotations, diagnostics, and an uninitialized operation value in #195 and #196, then implemented Daniel's command-enum proposal in #199.
- Daniel posted the polished final patch in #200 and committed it as a5cf808be5 with light cleanup and an additional test, confirming the landing in #202.
- Tom Lane reported missing unsigned-char casts and resulting undefined behavior in #204; Pavel supplied the seven-cast correction in #205, which landed unchanged as 17935e1fdf.
- Daniel confirmed applying the correction in #206, and Pavel's closing thanks in #207 left the filter feature and its immediate warning fix landed, with no remaining patch awaiting action in this thread.