Jun 2020

3 commits
Fix instance of elog() called while holding a spinlock
4 Jun 2020Michael Paquiermaster13beta2REL_19_STABLE13beta2REL_18_STABLE13beta2REL_17_STABLE13beta2REL_16_STABLE13beta2REL_15_STABLE13beta2REL_14_STABLE13beta2REL_13_STABLE13beta2+5 more
LLM analysis, 100% surelanded as postedfrom patchset #6

Both hunks in src/backend/replication/logical/logical.c match #6, with only declaration whitespace changed: release the mutex before logging and copy shared fields into local variables. Michael confirmed the fix and backpatching in #17.

Don't call palloc() while holding a spinlock, either.
3 Jun 2020Tom Lanemaster13beta2REL_19_STABLE13beta2REL_18_STABLE13beta2REL_17_STABLE13beta2REL_16_STABLE13beta2REL_15_STABLE13beta2REL_14_STABLE13beta2REL_13_STABLE13beta2+3 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Tom identified allocation and name-copy violations and proposed local ReplicationSlot snapshots in #11, then identified InvalidateObsoleteReplicationSlots() in #14. The commit implements those repairs in slot.c and slotfuncs.c, with slot.h macro cleanup; no attached patch contains them.

Don't call elog() while holding spinlock.
2 Jun 2020Fujii Masaomaster13beta2REL_19_STABLE13beta2REL_18_STABLE13beta2REL_17_STABLE13beta2REL_16_STABLE13beta2REL_15_STABLE13beta2REL_14_STABLE13beta2REL_13_STABLE13beta2
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The single UpdateSpillStats() hunk in src/backend/replication/walsender.c exactly matches #1, moving the spinlocked assignments after elog(DEBUG2). Fujii confirmed pushing it in #4.

  • Amit Kapilasaw the final versiontrailerAmit approved the patch and offered to push it in #3, and the committed code is unchanged.
  • Fujii Masaosaw the final versiontrailerFujii approved the patch in #2 and committed it, as confirmed in #4.

Credits across 3 commits

Author
Kyotaro Horiguchi1
Michael PaquierLLM1
Reviewer
Amit Kapila1
Fujii Masao1
Committer
Fujii Masao1
Michael Paquier1
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.