Nov 2020

1 commit
Remove catalog function currtid()
25 Nov 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #280 of 3 reviewers saw the final version

Applying #28 against the commit's parent reproduces every changed file except the dated catalog-version bump and two whitespace-only adjustments in src/backend/utils/adt/tid.c. Michael confirms applying this version while preserving currtid2() compatibility in #29.

  • Hiroshi Inouesaw an earlier versionLLM analysis, 91% sureAfter #1, he identified the driver's continuing currtid2() dependency and explained how removal could break keyset-driven cursors in #8 and #10, before substantial revisions.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 88% sureHe challenged the removal in #18 because currtid2() remained in use and requested retaining it in #19, which the subsequent patches implemented.
  • Tom Lanesaw an earlier versionLLM analysis, 99% sureHe opposed removing the still-referenced currtid2() in #20 and identified the signature-compatibility risk in #23 at #24, prompting the subsequent internal-helper refactoring.

Credits across 1 commit

Author
Michael PaquierLLM1
Committer
Michael Paquier1

N LLM means N of the credits come from LLM analysis, not from commit trailers.