[PATCH] pg_dump: Add example and link for --encoding option

Started by 이동욱over 5 years ago4 messages

이동욱

sh95119@gmail.com

over 5 years ago

1 attachment(s)

To let users know what kind of character set
can be used add examples and a link to --encoding option.

Thanks,
Dong wook

Attachments:

0001-pg_dump-Add-example-and-link-for-encoding-option.patchapplication/octet-stream; name=0001-pg_dump-Add-example-and-link-for-encoding-option.patchDownload

From 09dc6b40d222c48d70c3b935b3c6aba5f2c63bfe Mon Sep 17 00:00:00 2001
From: Lee Dong Wook <sh95119@gmail.com>
Date: Thu, 4 Jun 2020 21:54:33 +0900
Subject: [PATCH] pg_dump: Add example and link for --encoding option

To let users know what kind of character set
can be used add examples and a link to --encoding option.
---
 doc/src/sgml/ref/pg_dump.sgml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 197b5c0d70..e762aaf559 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -226,6 +226,8 @@ PostgreSQL documentation
         the dump is created in the database encoding.  (Another way to get the
         same result is to set the <envar>PGCLIENTENCODING</envar> environment
         variable to the desired dump encoding.)
+        You can also use variable character set (i.e. UTF8, EUC_KR, EUC_JP, EUC_CN ... etc)
+        and you can see the all supported character set in PostgreSQL (see <xref linkend="charset"/>)
        </para>
       </listitem>
      </varlistentry>
-- 
2.23.0

이동욱

sh95119@gmail.com

over 5 years ago

In reply to: 이동욱 (#1)

1 attachment(s)

Re: [PATCH] pg_dump: Add example and link for --encoding option

I've modified my previous patch because it linked the wrong document so I
fixed it. and I add a highlight to the encoding list for readability.

What do you think about this change?

Thanks,
Dong Wook

2020년 6월 4일 (목) 오후 10:20, 이동욱 <sh95119@gmail.com>님이 작성:

Show quoted text

To let users know what kind of character set
can be used add examples and a link to --encoding option.

Thanks,
Dong wook

Attachments:

v2-0001-pg_dump-Add-example-and-link-for-encoding-option.patchapplication/octet-stream; name=v2-0001-pg_dump-Add-example-and-link-for-encoding-option.patchDownload

From 890ab97aa211dc6fe99ce54bc5522afd5d614081 Mon Sep 17 00:00:00 2001
From: Lee Dong Wook <sh95119@gmail.com>
Date: Thu, 4 Jun 2020 21:54:33 +0900
Subject: [PATCH] pg_dump: Add example and link for --encoding option

To let users know what kind of character set
can be used add examples and a link to --encoding option.
---
 doc/src/sgml/ref/pg_dump.sgml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 197b5c0d70..9915f35f14 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -226,6 +226,8 @@ PostgreSQL documentation
         the dump is created in the database encoding.  (Another way to get the
         same result is to set the <envar>PGCLIENTENCODING</envar> environment
         variable to the desired dump encoding.)
+        You can also use variable character set (<envar>i.e. UTF8, EUC_KR, EUC_JP, EUC_CN ... etc</envar>)
+        and you can see the all supported character set in PostgreSQL (see <xref linkend="multibyte-charset-supported"/>)
        </para>
       </listitem>
      </varlistentry>
-- 
2.23.0

Dong Wook Lee

sh95119@gmail.com

over 5 years ago

In reply to: 이동욱 (#2)

1 attachment(s)

Fwd: [PATCH] pg_dump: Add example and link for --encoding option

2020년 6월 5일 (금) 오후 9:45, 이동욱 <sh95119@gmail.com>님이 작성:

Show quoted text

I've modified my previous patch because it linked the wrong document so I
fixed it. and I add a highlight to the encoding list for readability.

What do you think about this change?

Thanks,
Dong Wook

2020년 6월 4일 (목) 오후 10:20, 이동욱 <sh95119@gmail.com>님이 작성:

To let users know what kind of character set
can be used add examples and a link to --encoding option.

Thanks,
Dong wook

Attachments:

v2-0001-pg_dump-Add-example-and-link-for-encoding-option.patchapplication/x-patch; name=v2-0001-pg_dump-Add-example-and-link-for-encoding-option.patchDownload

From 890ab97aa211dc6fe99ce54bc5522afd5d614081 Mon Sep 17 00:00:00 2001
From: Lee Dong Wook <sh95119@gmail.com>
Date: Thu, 4 Jun 2020 21:54:33 +0900
Subject: [PATCH] pg_dump: Add example and link for --encoding option

To let users know what kind of character set
can be used add examples and a link to --encoding option.
---
 doc/src/sgml/ref/pg_dump.sgml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 197b5c0d70..9915f35f14 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -226,6 +226,8 @@ PostgreSQL documentation
         the dump is created in the database encoding.  (Another way to get the
         same result is to set the <envar>PGCLIENTENCODING</envar> environment
         variable to the desired dump encoding.)
+        You can also use variable character set (<envar>i.e. UTF8, EUC_KR, EUC_JP, EUC_CN ... etc</envar>)
+        and you can see the all supported character set in PostgreSQL (see <xref linkend="multibyte-charset-supported"/>)
        </para>
       </listitem>
      </varlistentry>
-- 
2.23.0

Peter Eisentraut

peter.eisentraut@2ndquadrant.com

over 5 years ago

In reply to: 이동욱 (#2)

Re: [PATCH] pg_dump: Add example and link for --encoding option

On 2020-06-05 14:45, 이동욱 wrote:

I've modified my previous patch because it linked the wrong document so
I fixed it. and I add a highlight to the encoding list for readability.

What do you think about this change?

The wording in your patch needed a bit of editing but adding a link to
the supported encodings seems sensible. I have committed it with a new
wording.

Thanks,
Dong Wook

2020년 6월 4일 (목) 오후 10:20, 이동욱 <sh95119@gmail.com
<mailto:sh95119@gmail.com>>님이 작성:

To let users know what kind of character set
can be used add examples and a link to --encoding option.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services