Sep 2020

4 commits
Use plain memset() in numeric.c, not MemSet and friends.
8 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The single numeric.c hunk replaces MemSetAligned with memset in init_var(), exactly matching Tom Lane's inline fix in #13. Neither attached patch contains this change.

Frob numeric.c loop so that clang will auto-vectorize it too.
7 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

After finding that clang could not vectorize the committed loop in #10, Tom Lane changed its inclusive bound to an exclusive i2limit and localized the temporary variables in numeric.c. He explained the successful experiment in #12; neither attachment contains this follow-up.

Apply auto-vectorization to the inner loop of numeric multiplication.
7 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81 of 2 reviewers saw the final version

This takes the numeric.c loop rewrite and numeric.o compiler flags from #8, leaving the flag-splitting infrastructure to 695de5d1ed. Tom Lane renamed digptr, exchanged the index-variable names, expanded the comment, and used CFLAGS_VECTORIZE, consistent with his cosmetic-edit report in #9.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% surePeter tested #1 under both -O2 and -O3 in #2 and requested per-file vectorization flags in #5, before #8 added compiler-option integration that he did not subsequently review.
  • Tom Lanesaw the final versioncommittercommitted the patch
Split Makefile symbol CFLAGS_VECTOR into two symbols.
7 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81 of 1 reviewer saw the final version

This extracts the configure and Makefile flag split from #8, retaining both optimizations for checksum.o while leaving numeric changes to 8870917623. Besides rebasing configure.in to configure.ac, Tom Lane renamed the remaining vectorization variable to CFLAGS_VECTORIZE and adjusted comments and ordering.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
Amit KhandekarLLM2
Reviewer
Tom Lanecommitter2
Committer
Tom Lane4

N LLM means N of the credits come from LLM analysis, not from commit trailers.