Jun 2020

3 commits
Expand tests for factorial
18 Jun 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The commit matches the second patch in #1, moving factorial tests from int4 to numeric and adding edge cases, with an additional SELECT -4! and corresponding expected output. Ashutosh requested that operator test in #2, and Peter accepted it in #5.

  • Ashutosh Bapatsaw the final versionLLM analysis, 100% sureAshutosh reviewed the regression changes and requested negative-argument operator coverage in #2, which Peter accepted in #5.
Disallow factorial of negative numbers
18 Jun 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The third patch in #1 supplies the negative-input check in src/backend/utils/adt/numeric.c. The commit adopts Tom Lane's singular error wording and retains the equivalent num <= 1 condition from #3, and updates expected output for the additional -4! test.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom proposed the error wording and simpler condition in #3, both incorporated into the commit.
  • Ashutosh Bapatsaw the final versionLLM analysis, 94% sureAshutosh examined the negative-input error branch and challenged its SQLSTATE in #2, although the original error category was retained.
doc: Document factorial function
16 Jun 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The commit reproduces the first patch in #1 in doc/src/sgml/func.sgml, changing only the documented argument type from numeric to bigint. Tom Lane identified that signature error in #4.

  • Tom Lanesaw the final versiontrailerTom checked the function signature against the catalogs and code in #4, prompting the only substantive documentation correction.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Tom Lane1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.