Aug 2020

4 commits
Add regression test for pg_backend_memory_contexts.
26 Aug 2020Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #542 of 2 reviewers saw the final version

The changes to src/test/regress/sql/sysviews.sql and expected/sysviews.out exactly match #54, including the TopMemoryContext query and expected result.

  • Michael Paquiersaw the final versiontrailerAccepted the initial regression test in #49, after which #54 made only a test-level refinement.
  • Fujii Masaosaw the final versiontrailerRequested stronger level-zero checks in #51, accepted the revision in #56, and committed the final test.
Move codes for pg_backend_memory_contexts from mmgr/mcxt.c to adt/mcxtfuncs.c.
26 Aug 2020Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 92% surepart of a posted patchsetlight changesfrom patchset #482 of 2 reviewers saw the final version

This is the relocation component of the three-patch submission #48, moving the SQL functions into adt/mcxtfuncs.c and updating its Makefile. Although the attachment bodies are unavailable, #49 describes a line-for-line move and #55 explicitly confirms that this submitted relocation patch would be committed.

  • Michael Paquiersaw the final versiontrailerChecked the line-for-line relocation in #49 and defended the utils/adt location and existing copyright convention in #53.
  • Fujii Masaosaw the final versiontrailerReviewed placement and copyright in #52, accepted the submitted relocation in #55, and committed it.
Prevent non-superusers from reading pg_backend_memory_contexts, by default.
26 Aug 2020Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #501 of 2 reviewers saw the final version

The catalogs.sgml documentation and both PUBLIC privilege revocations exactly match #50; the commit additionally bumps src/include/catalog/catversion.h.

  • Michael Paquiersaw an earlier versiontrailerIn #49, challenged the pg_monitor policy and identified the missing view revocation, prompting the access-control revision in #50.
  • Fujii Masaosaw the final versiontrailerReviewed the follow-up patches and accepted the revised restrictions in #51, then committed the final version.
Add pg_backend_memory_contexts system view.
19 Aug 2020Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #361 of 5 reviewers saw the final version

The commit matches #36 except for NULL-name handling and an equivalent parent-condition rewrite in mmgr/mcxt.c, plus a catalog-version bump. The commit credits Atsushi Torikoshi and Fujii Masao as co-authors; the submitting author already supplied the patch.

  • Tatsuhito Kasaharasaw an earlier versiontrailerCompared parent names with addresses in #26 and reported successful feature, documentation and installcheck-world testing of #27 in #29, before later helper and NULL-handling changes.
  • Andres Freundsaw an earlier versiontrailerIn #22, challenged reliance on row order for parent identification and proposed context addresses, before the address experiment and subsequent implementation revisions.
  • Daniel Gustafssonsaw an earlier versiontrailerRequested removal of the submitted catalog-version bump in #12, before the implementation moved out of the statistics subsystem and underwent further changes.
  • Robert Haassaw an earlier versiontrailerIn #28, explained why removing exposed addresses protected ASLR, before subsequent helper refactoring and NULL-name handling.
  • Michael Paquiersaw the final versiontrailerDiscussed pointer-exposure risks in #30 and explicitly inspected the committed implementation in #40, requesting regression coverage and relocation of its SQL functions.

Credits across 4 commits

Author
torikoshia4
Fujii Masao1
Reviewer
Michael Paquier4
Fujii Masao3
Andres Freund1
Daniel Gustafsson1
Robert Haas1
Tatsuhito Kasahara1
Committer
Fujii Masao4