Apr 2021

1 commit
postgres_fdw: Add option to control whether to keep connections open.
2 Apr 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1731 of 3 reviewers saw the final version

Matches #173 modulo rebase offsets, including the cached keep_connections Boolean, server-option validation, regression tests, and documentation.

  • Alexey Kondratovsaw an earlier versiontrailerReviewed the server option and its interaction with the GUC in #38, before the later precedence changes and server-only simplification.
  • Vignesh Csaw an earlier versiontrailerReviewed configuration placement and reported a regression failure in #2 and #3, before replacement of the core GUC design.
  • Fujii Masaosaw the final versiontrailerReviewed option semantics in #167 and #169, supplied the simplified server-only version in #172, and committed the final patch.

Jan 2021

7 commits
postgres_fdw: Fix tests for CLOBBER_CACHE_ALWAYS.
30 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1601 of 1 reviewer saw the final version

The SQL and expected-output blobs match #160; apparent diff differences are hunk alignment only. Fujii extracted and revised the test portion of Bharath's #159, as the commit explicitly credits.

  • Fujii Masaosaw the final versiontrailerExtracted the test-only solution and tested it with and without CLOBBER_CACHE_ALWAYS in #160, then committed it.
postgres_fdw: Fix test failure with -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
26 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1371 of 1 reviewer saw the final version

Exactly matches the regression role-name changes in #137, adding regress_ prefixes in contrib/postgres_fdw/sql/postgres_fdw.sql and its expected output.

  • Fujii Masaosaw the final versioncommittercommitted the patch
postgres_fdw: Stabilize regression test for postgres_fdw_disconnect_all().
26 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

After Tom's buildfarm report in #132, Fujii proposed suppressing unordered disconnect warnings with client_min_messages=ERROR in #133 and announced the fix in #135; no matching patch attachment preceded it.

postgres_fdw: Add functions to discard cached connections.
26 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1291 of 4 reviewers saw the final version

Matches Fujii's forwarded revision #129 except for correcting 'correspoinding' in doc/src/sgml/postgres-fdw.sgml. The commit credits Bharath's implementation, developed through #128, with Fujii's tweaks.

  • Alexey Kondratovsaw an earlier versiontrailerReviewed disconnect logic and transaction safety in #36, #66, and #69, before later API, lookup, and multiple-mapping corrections.
  • Zhijie Housaw an earlier versiontrailerQuestioned cache-state handling in #64 and requested tests and scan-condition cleanup in #111, before OID matching and multiple-connection fixes.
  • Zhihong Yusaw an earlier versiontrailerReviewed warning placement and diagnostics in #74 and #88, before the helper and multi-connection behavior were revised.
  • Fujii Masaosaw the final versiontrailerDrove the API and correctness revisions, demonstrated the multiple-user-mapping issue in #120, prepared #129, and committed the final version.
doc: Add note about the server name of postgres_fdw_get_connections() returns.
19 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1002 of 2 reviewers saw the final version

Exactly matches the documentation patch posted by Fujii in #100. Bharath supplied its final NULL-server-name wording in #97 and is credited in the patch and commit.

  • Zhijie Housaw the final versiontrailerIdentified the documentation gap in #92 and endorsed the posted correction in #101.
  • Fujii Masaosaw the final versiontrailerReviewed the wording in #96, posted the resulting patch in #100, and committed it.
postgres_fdw: Add function to list cached connections to foreign servers.
18 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #912 of 4 reviewers saw the final version

Matches #91 exactly, including the materialized listing function, extension upgrade, documentation, and public-user-mapping test adjustment; Fujii confirms pushing this version in #93.

  • Zhijie Housaw the final versiontrailerReviewed invalidated-connection visibility in #64 and identified missing NULL-name documentation in the final patch in #92.
  • Alexey Kondratovsaw an earlier versiontrailerReviewed dropped-server handling and its explanation in #69 and #71, before record output and materialization replaced the array implementation.
  • Zhihong Yusaw an earlier versiontrailerReviewed the validity representation in #74, before the listing interface changed from textual arrays to materialized records.
  • Fujii Masaosaw the final versiontrailerDrove the listing interface and implementation reviews, extracted it in #90, and committed the test-corrected version from #91.
postgres_fdw: Save foreign server OID in connection cache entry.
15 Jan 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #831 of 1 reviewer saw the final version

Exactly matches the standalone serverid patch in #83, extracted by Fujii from Bharath's series. The field and direct server lookup already appear in Bharath's #68, and the commit credits him.

  • Fujii Masaosaw the final versiontrailerReviewed the combined patch, extracted its server-OID changes in #83, and announced commitment in #85.

Credits across 8 commits

Author
Bharath Rupireddy1 LLM7
tweaked a bit by Fujii Masao1
tweaked by Fujii Masao1
Reviewer
Fujii Masaocommitter7
Alexey Kondratov3
Zhijie Hou3
Zhihong Yu2
vignesh C1
Reported by
Tom Lane1
Committer
Fujii Masao8

N LLM means N of the credits come from LLM analysis, not from commit trailers.