[PATCH] fix size sum table_parallelscan_estimate (src/backend/access/table/tableam.c)
Started by Ranier Vilelaover 5 years ago2 messages
Hi,
Fix typo on sum size table_parallelscan_estimate.
If IsMVCCSnapshot(snapshot is true, add_size return is being lost.
regards,
Ranier Vilela
Attachments:
fix_table_parallelscan_estimate_size.patchapplication/octet-stream; name=fix_table_parallelscan_estimate_size.patchDownload
diff --git a/src/backend/access/table/tableam.c b/src/backend/access/table/tableam.c
index c814733b22..c6c1fec4f7 100644
--- a/src/backend/access/table/tableam.c
+++ b/src/backend/access/table/tableam.c
@@ -125,14 +125,17 @@ table_scan_update_snapshot(TableScanDesc scan, Snapshot snapshot)
Size
table_parallelscan_estimate(Relation rel, Snapshot snapshot)
{
- Size sz = 0;
+ Size sz;
if (IsMVCCSnapshot(snapshot))
sz = add_size(sz, EstimateSnapshotSpace(snapshot));
else
+ {
Assert(snapshot == SnapshotAny);
+ sz = 0;
+ }
- sz = add_size(sz, rel->rd_tableam->parallelscan_estimate(rel));
+ sz += add_size(sz, rel->rd_tableam->parallelscan_estimate(rel));
return sz;
}
Re: [PATCH] fix size sum table_parallelscan_estimate (src/backend/access/table/tableam.c)
On 2020-Jun-23, Ranier Vilela wrote:
Hi,
Fix typo on sum size table_parallelscan_estimate.
If IsMVCCSnapshot(snapshot is true, add_size return is being lost.
add_size() already adds, no? You don't need to add again.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services