model-writtenrun 8307 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed enabling -Wcast-function-type and fixing three groups of warnings: dynamic-loader return types, the strlcpy callback in dynahash, and PL/Python method casts #1.
- Tom Lane recommended returning void * from the dlsym wrappers and avoiding an extra dynahash wrapper call #2; Andres Freund questioned the cast restrictions and discussed whether the wrapper could be optimized #4, while Tom established that GCC explicitly documents void (*)(void) as its warning escape hatch #5.
- Peter noted that CPython used the same intermediate function-pointer cast #6, and Tom accepted that documented convention while favoring a typedef for a centralized explanation and future changes #7.
- Peter's next patch adopted void * loader returns and direct intermediate casts for dynahash and PL/Python #8; Tom requested a typedef for readability and documentation #9, which Peter supplied as pg_funcptr_t in the next revision #10.
- Tom reported that the final revision passed an eyeball check, although he lacked a compiler that emitted the warnings #11.
- Peter committed #10 as de8feb1f3a, with only typedef placement and comment cleanup, and closed the thread by confirming that the work had landed #12.