Sep 2020

1 commit
Allow incremental sorts for windowing functions
15 Sep 2020David Rowleymaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 2 reviewers saw the final version

The diff for 62e221e1c0 matches #4 except that the final argument to create_incremental_sort_path() changes from -1 to -1.0 in src/backend/optimizer/plan/planner.c; both regression files match exactly. David Rowley confirms the push in #8.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reported performance testing and identified the missing enable_incremental_sort check and tests in #2, then approved the revised patch in #5.
  • Tomas Vondrasaw an earlier versiontrailerTomas assessed the initial patch as correct and discussed independent pathkey-reordering opportunities in #3, before #4 added the enable_incremental_sort logic check and regression tests.

Credits across 1 commit

Author
David Rowley1
Reviewer
Daniel Gustafsson1
Tomas Vondra1
Committer
David Rowley1