Sep 2020

3 commits
Assign collations in partition bound expressions.
28 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11

The commit takes the assign_expr_collations() insertion from #11 in src/backend/parser/parse_utilcmd.c and adds regression tests for string comparisons in boolean partition bounds. The draft's removal of collation checks landed separately in 2dfa3fea88, allowing this bug fix to be backpatched.

Remove complaints about COLLATE clauses in partition bound values.
28 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11

The commit takes the complete collation-check deletion from #11 in transformPartitionBoundValue(), with regression SQL and expected-output adjustments. Its assign_expr_collations() addition was split into 72647ac3bf.

Improve error cursor positions for problems with partition bounds.
23 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: Report error position in partition bound check (not this thread)
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #61 of 2 reviewers saw the final version

The commit matches Alexandra Wang's patch forwarded and revised in #6, later than all listed submissions in thread #42202. Besides naming, comments and header cleanup, Tom Lane restored unconditional Const location assignment, reverted the coercion-location argument, and removed the positive-location assertion.

  • Ashutosh Bapatsaw an earlier versionLLM analysis, 94% sureAshutosh requested comparison documentation in #2, questioned location preservation in #5, and reviewed the revised evaluation and comments in #7, before the committer's local location-handling changes.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Tom LaneLLM2
Alexandra WangLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.