Patch for reorderbuffer.c documentation.
This started out with just fixing
"One option do deal" to " One option to deal"
But after reading the rest I'd propose the following patch.
Dave Cramer
Attachments:
reorderdoc.patchapplication/octet-stream; name=reorderdoc.patchDownload
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index 5251932669..4adbe21dfc 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -47,7 +47,7 @@
* ReorderBuffer uses two special memory context types - SlabContext for
* allocations of fixed-length structures (changes and transactions), and
* GenerationContext for the variable-length transaction data (allocated
- * and freed in groups with similar lifespan).
+ * and freed in groups with similar lifespans).
*
* To limit the amount of memory used by decoded changes, we track memory
* used at the reorder buffer level (i.e. total amount of memory), and for
@@ -58,7 +58,7 @@
* Only decoded changes are evicted from memory (spilled to disk), not the
* transaction records. The number of toplevel transactions is limited,
* but a transaction with many subtransactions may still consume significant
- * amounts of memory. The transaction records are fairly small, though, and
+ * amounts of memory. The transaction records are fairly small though and
* are not included in the memory limit.
*
* The current eviction algorithm is very simple - the transaction is
@@ -69,13 +69,13 @@
*
* We still rely on max_changes_in_memory when loading serialized changes
* back into memory. At that point we can't use the memory limit directly
- * as we load the subxacts independently. One option do deal with this
+ * as we load the subxacts independently. One option to deal with this
* would be to count the subxacts, and allow each to allocate 1/N of the
* memory limit. That however does not seem very appealing, because with
- * many subtransactions it may easily cause trashing (short cycles of
+ * many subtransactions it may easily cause thrashing (short cycles of
* deserializing and applying very few changes). We probably should give
* a bit more memory to the oldest subtransactions, because it's likely
- * the source for the next sequence of changes.
+ * they are the source for the next sequence of changes.
*
* -------------------------------------------------------------------------
*/
On Fri, Jul 17, 2020 at 8:10 AM Dave Cramer <davecramer@gmail.com> wrote:
This started out with just fixing
"One option do deal" to " One option to deal"
But after reading the rest I'd propose the following patch.
Suggest replacing "though" with "however" instead of trying to figure out
what amount of commas is readable (the original seemed better IMO).
"However, the transaction records are fairly small and"
The rest is straight-forward.
David J.
On Fri, 17 Jul 2020 at 11:17, David G. Johnston <david.g.johnston@gmail.com>
wrote:
On Fri, Jul 17, 2020 at 8:10 AM Dave Cramer <davecramer@gmail.com> wrote:
This started out with just fixing
"One option do deal" to " One option to deal"
But after reading the rest I'd propose the following patch.
Suggest replacing "though" with "however" instead of trying to figure out
what amount of commas is readable (the original seemed better IMO)."However, the transaction records are fairly small and"
Works for me.
Thanks,
Dave
On Fri, Jul 17, 2020 at 8:59 PM Dave Cramer <davecramer@gmail.com> wrote:
On Fri, 17 Jul 2020 at 11:17, David G. Johnston <david.g.johnston@gmail.com> wrote:
On Fri, Jul 17, 2020 at 8:10 AM Dave Cramer <davecramer@gmail.com> wrote:
This started out with just fixing
"One option do deal" to " One option to deal"
But after reading the rest I'd propose the following patch.
Suggest replacing "though" with "however" instead of trying to figure out what amount of commas is readable (the original seemed better IMO).
"However, the transaction records are fairly small and"
Works for me.
Thanks, pushed.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com