Patch for nodeIncrementalSort comment correction.
Hi,
One of the comments needs correction "sorting all tuples in the the
dataset" should have been "sorting all tuples in the dataset".
The Attached patch has the changes for the same.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
Attachments:
0001-Adjust-minor-comment-in-nodeIncrementalSort.c-file.patchtext/x-patch; charset=US-ASCII; name=0001-Adjust-minor-comment-in-nodeIncrementalSort.c-file.patchDownload
From cac50bde06ba4493f278b3a79d15d2591f45344b Mon Sep 17 00:00:00 2001
From: Vignesh C <vignesh21@gmail.com>
Date: Sat, 18 Jul 2020 16:43:36 +0530
Subject: [PATCH] Adjust minor comment in nodeIncrementalSort.c file.
Adjust minor comment in nodeIncrementalSort.c file.
---
src/backend/executor/nodeIncrementalSort.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/executor/nodeIncrementalSort.c b/src/backend/executor/nodeIncrementalSort.c
index e056469..6c0d24e 100644
--- a/src/backend/executor/nodeIncrementalSort.c
+++ b/src/backend/executor/nodeIncrementalSort.c
@@ -65,8 +65,8 @@
* into the second mode if we believe it's beneficial.
*
* Sorting incrementally can potentially use less memory, avoid fetching
- * and sorting all tuples in the the dataset, and begin returning tuples
- * before the entire result set is available.
+ * and sorting all tuples in the dataset, and begin returning tuples before
+ * the entire result set is available.
*
* The hybrid mode approach allows us to optimize for both very small
* groups (where the overhead of a new tuplesort is high) and very large
--
1.8.3.1
On Saturday, July 18, 2020, vignesh C <vignesh21@gmail.com> wrote:
Hi,
One of the comments needs correction "sorting all tuples in the the
dataset" should have been "sorting all tuples in the dataset".
The Attached patch has the changes for the same.Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
Thanks for fixing this. Looks correct to me.
James
On Sun, Jul 19, 2020 at 7:25 PM James Coleman <jtc331@gmail.com> wrote:
On Saturday, July 18, 2020, vignesh C <vignesh21@gmail.com> wrote:
Hi,
One of the comments needs correction "sorting all tuples in the the
dataset" should have been "sorting all tuples in the dataset".
The Attached patch has the changes for the same.Thanks for fixing this. Looks correct to me.
Yeah, looks like a typo will push in some time.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com