Apr 2021

2 commits
Support INCLUDE'd columns in SP-GiST.
5 Apr 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #291 of 3 reviewers saw the final version

Implements the INCLUDE feature from #29, retaining its standard tuple construction/deconstruction and per-tuple picksplit approach. Tom Lane revises descriptor handling to distinguish input and leaf types, adjusts bitmap and scan logic, and replaces index_including_spgist.sql with focused tests; #30 confirms the edits and test removal.

  • Andrey Borodinsaw an earlier versionLLM analysis, 99% sureReviewed key-column enforcement, tuple layout, access macros, and descriptor initialization in #2, #9, #13, and #15, before the storage redesign; 09c1c6ab4b explicitly credits him.
  • Anastasia Lubennikovasaw an earlier versionLLM analysis, 100% sureReported passing tests and proposed naming, documentation, assertion, and regression-test improvements in #11, before the storage redesign; 09c1c6ab4b explicitly credits her.
  • Tom Lanesaw the final versioncommittercommitted the patch
Rethink handling of pass-by-value leaf datums in SP-GiST.
1 Apr 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 98% surepart of a posted patchsetmoderate changesfrom patchset #291 of 2 reviewers saw the final version

Extracts the standard-width pass-by-value leaf storage and fetch_att change present in #29, leaving INCLUDE support for the later commit. Tom Lane adds separate inner/leaf sizing and copying helpers in spgutils.c and guards null-key fetches in spgdoinsert.c; the commit explicitly identifies this as an extraction from the larger patch and credits Pavel Borisov and Tom Lane.

  • Andrey Borodinsaw an earlier versionLLM analysis, 88% sureExplicitly credited in 1ebdec8c03, he reviewed the parent patch's leaf layout and access macros in #9, #13, and #15, before the pass-by-value redesign.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Pavel BorisovLLM2
Reviewer
Tom Lanecommitter2
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.