Mar 2025

1 commit
Introduce squashing of constant lists in query jumbling
18 Mar 2025Álvaro Herreramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #1471 of 11 reviewers saw the final version

The commit matches #147 with an additional COERCE_EXPLICIT_CAST case in IsSquashableConst(), its changed regression expectation, and small formatting and SGML fixes. Álvaro confirms adding explicit-cast support and pushing in #150; the commit credits Dmitry, whose patch Álvaro took over in #140.

  • Sergey Dudoladovno review foundtrailerNo review activity appears in this thread; 62d712ecfd explicitly credits an off-list review.
  • David Geiersaw an earlier versiontrailerRequested corner-case tests, simpler eligibility checks and better coercion handling in #55, #58 and #61, before subsequent architectural and cast-handling changes.
  • Robert Haassaw an earlier versiontrailerSupported optional collapsing and reviewed whole-list behavior and documentation in #22, #25 and #27, before extensive redesign.
  • Álvaro Herrerasaw the final versiontrailerProposed size buckets, reviewed configuration and cast handling, revised the final patch and committed it, as documented in #53, #115, #147 and #150.
  • Sami Imseihsaw an earlier versiontrailerTested coercions and prepared parameters, found missing normalized-query text, and challenged volatility restrictions in #104, #117, #134 and #142, before the final cast-handling changes.
  • Sutou Kouheisaw an earlier versiontrailerReviewed node-attribute documentation, style and normalized-query allocation in #94, leading to fixes in #96 before later configuration and eligibility changes.
  • Tom Lanesaw an earlier versiontrailerChallenged expression evaluation and parameter conflation, advocated whole-list elision and questioned range metadata in #16, #29, #31 and #47.
  • Michael Paquiersaw an earlier versiontrailerReviewed location metadata and tests, requested splitting optional grouping, and proposed generic node annotations and extension-owned configuration in #45, #71 and #75.
  • Marcos Pegorarosaw an earlier versiontrailerReported a documentation typo in #40, corrected in #41, well before later implementation changes.
  • Julien Rouhaudsaw an earlier versiontrailerIdentified EXPLAIN GENERIC_PLAN incompatibility and parameter-numbering issues in #119 and #125, before subsequent changes to squashable cast recognition.
  • Zhihong Yusaw an earlier versiontrailerReviewed redundant scanning, code duplication and wording in #6, #8 and #14, before the implementation was substantially redesigned.

Credits across 1 commit

Author
Dmitry Dolgov1
Reviewer
Alvaro Herrera1
David Geier1
Julien Rouhaud1
Marcos Pegoraro1
Michael Paquier1
Robert Haas1
Sami Imseih1
Sergey Dudoladov1
Sutou Kouhei1
Tom Lane1
Zhihong Yu1
Tested by
Chengxi Sun1
Jakub Wartak1
Maciek Sakrejda1
Sergei Kornilov1
Yasuo Honda1
Committer
Alvaro Herrera1