Fix an old description in high-availability.sgml

Started by Masahiko Sawadaover 5 years ago4 messages
#1Masahiko Sawada
masahiko.sawada@2ndquadrant.com
1 attachment(s)

Hi,

The following sentence in high-availability.sgml is not true:

The background writer is active during recovery and will perform
restartpoints (similar to checkpoints on the primary) and normal block
cleaning activities.

I think this is an oversight of the commit 806a2ae in 2011; the
checkpointer process started to be responsible for creating
checkpoints.

I've attached the patch.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

fix_high_availability_doc.patchapplication/octet-stream; name=fix_high_availability_doc.patchDownload
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index a824d383f2..d6f79fc435 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -2380,9 +2380,10 @@ LOG:  database system is ready to accept read only connections
    </para>
 
    <para>
-    The background writer is active during recovery and will perform
-    restartpoints (similar to checkpoints on the primary) and normal block
-    cleaning activities. This can include updates of the hint bit
+    The checkpointer process and the background writer process are active during
+    recovery. The checkpointer process will perform restartpoints (similar to
+    checkpoints on the primary) and the background writer process will perform
+    normal block cleaning activities. This can include updates of the hint bit
     information stored on the standby server.
     The <command>CHECKPOINT</command> command is accepted during recovery,
     though it performs a restartpoint rather than a new checkpoint.
#2Michael Paquier
michael@paquier.xyz
In reply to: Masahiko Sawada (#1)
Re: Fix an old description in high-availability.sgml

On Fri, Aug 14, 2020 at 04:53:54PM +0900, Masahiko Sawada wrote:

The following sentence in high-availability.sgml is not true:

The background writer is active during recovery and will perform
restartpoints (similar to checkpoints on the primary) and normal block
cleaning activities.

I think this is an oversight of the commit 806a2ae in 2011; the
checkpointer process started to be responsible for creating
checkpoints.

Good catch it is. Your phrasing looks good to me.
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Fix an old description in high-availability.sgml

On Fri, Aug 14, 2020 at 05:15:20PM +0900, Michael Paquier wrote:

Good catch it is. Your phrasing looks good to me.

Fixed as b4f1639. Thanks.
--
Michael

#4Masahiko Sawada
masahiko.sawada@2ndquadrant.com
In reply to: Michael Paquier (#3)
Re: Fix an old description in high-availability.sgml

On Mon, 17 Aug 2020 at 10:32, Michael Paquier <michael@paquier.xyz> wrote:

On Fri, Aug 14, 2020 at 05:15:20PM +0900, Michael Paquier wrote:

Good catch it is. Your phrasing looks good to me.

Fixed as b4f1639. Thanks.

Thank you!

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services