Nov 2020

7 commits
Make pg_rewind test case more stable.
20 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Andres supplied an inline replication-wait fix in #15; Heikki adapted it to wait for B before pg_rewind, explaining the placement in #16. The commit changes only t/007_standby_source.pl and matches no attached patchset.

Fix timing issue in pg_rewind test.
15 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Tom diagnosed the test's insufficient wait in #13, proposing replay rather than WAL write completion; Heikki confirmed the fix in #14. The sole change replaces 'write' with 'replay' in t/007_standby_source.pl.

Allow pg_rewind to use a standby server as the source system.
12 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #80 of 2 reviewers saw the final version

The fifth patch in #8 supplies the request queue and standby minRecoveryPoint handling. The commit additionally fixes deleted-file chunk accounting, adjusts backup-label replay to the source restartpoint, and adds documentation and tests; #11 describes the final testing and deleted-file fix.

  • Kyotaro Horiguchisaw an earlier versiontrailerIn #5, Kyotaro reviewed #3's read-only setting, full_page_writes check, request merging and truncation handling, before the later recovery and deleted-file fixes.
  • Soumyadeep Chakrabortysaw an earlier versiontrailerIn #6, Soumyadeep reviewed #5's chunk-size naming, offset type and fetch code, before the later recovery and deleted-file fixes.
pg_rewind: Refactor the abstraction to fetch from local/libpq source.
4 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #81 of 2 reviewers saw the final version

The fourth patch in #8 supplies rewind_source, local_source.c, libpq_source.c and perform_rewind(). Final cleanup deletes the obsolete copy_fetch.c, removes the stale execute_file_actions declaration identified in #9, updates comments and formatting, and registers typedefs.

  • Kyotaro Horiguchisaw an earlier versiontrailerKyotaro reviewed the fetch abstraction in #2 and #5, before #8 reorganized execution and changed COPY initialization.
  • Soumyadeep Chakrabortysaw the final versiontrailerSoumyadeep proposed source-file and interface changes in #6 and caught the stale execute_file_actions declaration in #9, after which only light cleanup followed.
pg_rewind: Replace the hybrid list+array data structure with simplehash.
4 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #82 of 2 reviewers saw the final version

The third patch in #8 implements the committed simplehash conversion in filemap.c and filemap.h. Final edits rename FILEMAP_INITIAL_SIZE to FILEHASH_INITIAL_SIZE and correct comments, including obsolete backup-manifest and filemap_finalize references.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro examined hash iteration, hash_string_pointer reuse and filemap naming in #5, with only naming and comment changes following for this patch.
  • Soumyadeep Chakrabortysaw the final versiontrailerSoumyadeep proposed nentries/entries naming and a named initial-size constant in #6, which were incorporated with only light subsequent edits.
Refactor pg_rewind for more clear decision making.
4 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #82 of 2 reviewers saw the final version

The second patch in #8 supplies the separated collection and decision phases in filemap.c. The commit adds an explicit void parameter list to decide_file_actions(), corrects comments and applies formatting cleanup, consistent with #10.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro requested centralized exclusion decisions in #2 and reviewed the resulting revision in #5, followed by light naming, comment and assertion cleanup.
  • Soumyadeep Chakrabortysaw the final versiontrailerSoumyadeep reviewed file-decision comments, page-map naming, assertions and exclusions in #6, then discussed the remaining symlink case in #9.
pg_rewind: Move syncTargetDirectory() to file_ops.c
4 Nov 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #81 of 1 reviewer saw the final version

The first patch in #8 has the same added and removed lines as the commit: moving and renaming syncTargetDirectory() to sync_target_dir() in file_ops.c and updating declarations and its caller.

  • Michael Paquiersaw the final versiontrailerMichael specifically endorsed moving the target-directory sync routine to file_ops.c in #4, and that patch remained unchanged through #8.

Credits across 7 commits

Author
Heikki LinnakangasLLM5
Reviewer
Kyotaro Horiguchi4
Soumyadeep Chakraborty4
Michael Paquier1
Reported by
Andres Freund1
Committer
Heikki Linnakangas7

N LLM means N of the credits come from LLM analysis, not from commit trailers.