Fix typo in procarrary.c

Started by Masahiko Sawadaover 5 years ago5 messages

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

1 attachment(s)

Hi,

I've attached the patch for $subject.

s/replications lots/replication slots/

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

fix_typo.patchapplication/octet-stream; name=fix_typo.patchDownload

diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index 60b7a5db8e..ad1fdeae25 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -207,7 +207,7 @@ typedef struct ComputeXidHorizonsResult
 	 * Oldest xid for which deleted tuples need to be retained in shared
 	 * tables.
 	 *
-	 * This includes the effects of replications lots. If that's not desired,
+	 * This includes the effects of replication slots. If that's not desired,
 	 * look at shared_oldest_nonremovable_raw;
 	 */
 	TransactionId shared_oldest_nonremovable;

Fujii Masao

masao.fujii@oss.nttdata.com

over 5 years ago

In reply to: Masahiko Sawada (#1)

Re: Fix typo in procarrary.c

On 2020/08/21 10:58, Masahiko Sawada wrote:

Hi,

I've attached the patch for $subject.

s/replications lots/replication slots/

Thanks for the patch!

Also it's better to s/replications slots/replication slots/ ?

--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
          * be removed.
          *
          * This likely should only be needed to determine whether pg_subtrans can
-        * be truncated. It currently includes the effects of replications slots,
+        * be truncated. It currently includes the effects of replication slots,
          * for historical reasons. But that could likely be changed.
          */
         TransactionId oldest_considered_running;

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

In reply to: Fujii Masao (#2)

Re: Fix typo in procarrary.c

On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

On 2020/08/21 10:58, Masahiko Sawada wrote:

Hi,

I've attached the patch for $subject.

s/replications lots/replication slots/

Thanks for the patch!

Also it's better to s/replications slots/replication slots/ ?

--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
* be removed.
*
* This likely should only be needed to determine whether pg_subtrans can
-        * be truncated. It currently includes the effects of replications slots,
+        * be truncated. It currently includes the effects of replication slots,
* for historical reasons. But that could likely be changed.
*/
TransactionId oldest_considered_running;

Indeed. I agree with you.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Fujii Masao

masao.fujii@oss.nttdata.com

over 5 years ago

In reply to: Masahiko Sawada (#3)

Re: Fix typo in procarrary.c

On 2020/08/21 12:29, Masahiko Sawada wrote:

On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
On 2020/08/21 10:58, Masahiko Sawada wrote:

Hi,

I've attached the patch for $subject.

s/replications lots/replication slots/

Thanks for the patch!

Also it's better to s/replications slots/replication slots/ ?
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
* be removed.
*
* This likely should only be needed to determine whether pg_subtrans can
-        * be truncated. It currently includes the effects of replications slots,
+        * be truncated. It currently includes the effects of replication slots,
* for historical reasons. But that could likely be changed.
*/
TransactionId oldest_considered_running;
Indeed. I agree with you.

Thanks! So I pushed both fixes.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Masahiko Sawada

masahiko.sawada@2ndquadrant.com

over 5 years ago

In reply to: Fujii Masao (#4)

Re: Fix typo in procarrary.c

On Fri, 21 Aug 2020 at 12:39, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

On 2020/08/21 12:29, Masahiko Sawada wrote:
On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
On 2020/08/21 10:58, Masahiko Sawada wrote:

Hi,

I've attached the patch for $subject.

s/replications lots/replication slots/

Thanks for the patch!

Also it's better to s/replications slots/replication slots/ ?
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
* be removed.
*
* This likely should only be needed to determine whether pg_subtrans can
-        * be truncated. It currently includes the effects of replications slots,
+        * be truncated. It currently includes the effects of replication slots,
* for historical reasons. But that could likely be changed.
*/
TransactionId oldest_considered_running;
Indeed. I agree with you.
Thanks! So I pushed both fixes.

Thanks!

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services