Sep 2020

6 commits
Remove unused parameters
19 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

Combines the six pg_dump patches from #1, covering pg_backup_archiver.c, pg_backup_tar.c, pg_dump.c, dumputils.c, dumputils.h, and pg_dumpall.c. All 105 added and removed lines match those patches after whitespace normalization; differences are rebased context and consolidation.

  • Michael Paquiersaw the final versionLLM analysis, 97% sureMichael examined findNamespace() and _moveBefore() against sibling routines and concluded that inconsistent Archive usage justified the cleanup in #7.
  • Tom Lanesaw the final versionLLM analysis, 98% sureTom questioned parameter consistency in #2, then inspected pg_backup_archiver.c and withdrew his objection after finding existing inconsistency in #8.
Remove unused parameter
10 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1

Takes the CheckCopyStreamStop() cleanup in src/bin/pg_basebackup/receivelog.c from #1, removing stoppos from its declaration, definition, and two calls. All ten added and removed lines match the submitted component exactly.

Remove unused parameter
8 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

Takes the generate_normalized_query() cleanup in contrib/pg_stat_statements/pg_stat_statements.c from #1. All seven added and removed lines match the submitted removal of the encoding parameter.

  • Fujii Masaosaw the final versionLLM analysis, 93% sureFujii specifically examined the proposed encoding removal and explained that generate_normalized_query() had lost its use of that parameter in an earlier change in #5.
Remove unused parameter
6 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1

Takes the get_crosstab_tuplestore() cleanup in contrib/tablefunc/tablefunc.c from #1. Its three deletions exactly match removal of per_query_ctx from the declaration, call, and definition.

Remove unused parameter
4 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1

Takes the bt_page_print_tuples() cleanup in contrib/pageinspect/btreefuncs.c from #1. All six added and removed lines match the submitted removal of fctx from the definition and two callers.

Remove unused parameter
2 Sep 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1

Takes the read_cursor_args() cleanup in src/pl/plpgsql/src/pl_gram.y from #1. All nine added and removed lines match the submitted removal of expected from the declaration, definition, and callers.

Credits across 6 commits

Author
Peter EisentrautLLM6
Committer
Peter Eisentraut6

N LLM means N of the credits come from LLM analysis, not from commit trailers.