model-writtenrun 8201 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed eleven unused-parameter cleanup patches, documenting when each parameter became unnecessary or that it had never been used, in #1.
- Tom Lane raised the possibility of preserving unused parameters for consistency with sibling functions in #2; Bruce Momjian proposed documenting any intentional exceptions in #3, and Andreas Karlsson supported that documentation to prevent repeated cleanup proposals in #4.
- Fujii Masao examined the pg_stat_statements change and explained that the encoding parameter appeared to have been accidentally retained after its use disappeared from generate_normalized_query(), supporting its removal in #5.
- Peter clarified that he intended to exclude parameters retained for consistency in #6; Michael Paquier examined the proposed changes, including findNamespace() and _moveBefore(), and found the cleanup reasonable given existing inconsistencies in Archive usage in #7.
- In the final thread message, Tom narrowed his concern to pg_backup_archiver.c and withdrew it after inspecting that file's inconsistent ArchiveHandle usage, leaving no stated objection or requested revision outstanding in #8.
- Peter subsequently committed the unchanged PL/pgSQL component on September 2 as fd5e3b2914 and the unchanged pageinspect component on September 4 as 96cfcadd26, both from #1.
- The unchanged tablefunc and pg_stat_statements components from #1 landed on September 6 and September 8 as 76af9744db and 1dec091d5b, respectively.
- The unchanged CheckCopyStreamStop() component from #1 landed on September 10 as c02767d241.
- On September 19, Peter combined the six pg_dump components from #1 into 8354e7b27e, preserving their edits on a newer base and completing all eleven proposed patches across the six commits.