[PATCH v1] explicit_bzero.c: using explicit_memset on NetBSD

Started by David CARLIERabout 6 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrybuild failedCI history

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t42871_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t42871_1 && git checkout t42871_1

Patchset v1 (message #1) is on t42871_1

Jump to latest
#1David CARLIER
devnexen@gmail.com

Thanks.

Regards.

Attachments:

t42871_1
0001-explicit_bzero.c-uses-explicit_memset-for-NetBSD.patchapplication/octet-stream; name=0001-explicit_bzero.c-uses-explicit_memset-for-NetBSD.patchDownload+25-1
#2Michael Paquier
michael@paquier.xyz
In reply to: David CARLIER (#1)
Re: [PATCH v1] explicit_bzero.c: using explicit_memset on NetBSD

On Sun, Aug 30, 2020 at 02:03:32PM +0100, David CARLIER wrote:

Thanks.

During the addition of explicit_bzero(), there was an agreement to use
memset_s(), as it is blessed by the standard:
/messages/by-id/20190717211931.GA906@alvherre.pgsql

So what would be the advantage of explicit_memset() knowing that
NetBSD has memset_s()? This also means that your patch is a no-op for
NetBSD as HAVE_MEMSET_S would be set.
--
Michael