Sep 2020

2 commits
Add d_type to our Windows dirent emulation.
7 Sep 2020Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #192 of 4 reviewers saw the final version

Commits only the Windows component of the two-patch submission #19, with formatting and an 'identified' typo correction in src/port/dirent.c, as confirmed in #25. The committed struct layout excludes the subsequent proposal in #20.

  • Alvaro Herrerasaw an earlier versiontrailerQuestioned the enum and self-referential macros in #9 and #11, before the Windows attribute lookup logic was revised.
  • Andres Freundsaw an earlier versiontrailerExplained in #15 and #18 that adding GetFileAttributes() to readdir() would penalize other callers, prompting its replacement with existing directory-entry information.
  • Magnus Hagandersaw the final versiontrailerConfirmed in #24 that junctions use IO_REPARSE_TAG_MOUNT_POINT and explained the historical reparse-point handling.
  • Thomas Munrosaw the final versiontrailerExamined syscall costs in #4, proposed using dwFileAttributes in #17, checked junction detection in #21, and committed the final version.
Skip unnecessary stat() calls in walkdir().
7 Sep 2020Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #192 of 2 reviewers saw the final version

Commits the shared walkdir() component carried unchanged from #8 into #19, with get_dirent_type() relocated into src/common/file_utils.c, corresponding build guards, comment edits, and removal of the unused DT_UNKNOWN availability test. Thomas confirmed this packaging change in #23; the early-return rewrite in #20 was not used.

  • Tom Lanesaw the final versiontrailerRequested the reusable API in #2, centralized error reporting in #5 and #7, and the final file_utils.c placement in #22.
  • Juan José Santamaría Flechasaw the final versiontrailerExtended the original optimization to Windows in #3 and checked the shared helper's macro-based feature detection in #12, after which that component received only light integration edits.

Credits across 2 commits

Author
Juan José Santamaría Flecha1
Thomas MunroLLM1
Reviewer
Alvaro Herrera1
Andres Freund1
Juan José Santamaría Flecha1
Magnus Hagander1
Thomas Munro1
Tom Lane1
Committer
Thomas Munro2

N LLM means N of the credits come from LLM analysis, not from commit trailers.