Use <unnamed> for name of unnamed portal's memory context

Started by Peter Eisentrautover 5 years ago5 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I propose the attached little patch to set the name of the memory
context of an unnamed portal to "<unnamed>" instead of just an empty
string. Otherwise the debug memory context dump looks a little
confusing. We use this convention elsewhere for making unnamed
statements etc. more clearly visible.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

0001-Use-unnamed-for-name-of-unnamed-portal-s-memory-cont.patchtext/plain; charset=UTF-8; name=0001-Use-unnamed-for-name-of-unnamed-portal-s-memory-cont.patch; x-mac-creator=0; x-mac-type=0Download+1-2
#2Pavel Stehule
pavel.stehule@gmail.com
In reply to: Peter Eisentraut (#1)
Re: Use <unnamed> for name of unnamed portal's memory context

so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> napsal:

I propose the attached little patch to set the name of the memory
context of an unnamed portal to "<unnamed>" instead of just an empty
string. Otherwise the debug memory context dump looks a little
confusing. We use this convention elsewhere for making unnamed
statements etc. more clearly visible.

+1

Pavel

Show quoted text

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#3Julien Rouhaud
rjuju123@gmail.com
In reply to: Pavel Stehule (#2)
Re: Use <unnamed> for name of unnamed portal's memory context

On Sat, Sep 5, 2020 at 8:25 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:

so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <peter.eisentraut@2ndquadrant.com> napsal:

I propose the attached little patch to set the name of the memory
context of an unnamed portal to "<unnamed>" instead of just an empty
string. Otherwise the debug memory context dump looks a little
confusing. We use this convention elsewhere for making unnamed
statements etc. more clearly visible.

+1

+1 too, and obviously patch looks good.

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Julien Rouhaud (#3)
Re: Use <unnamed> for name of unnamed portal's memory context

Julien Rouhaud <rjuju123@gmail.com> writes:

+1 too, and obviously patch looks good.

The adjacent comment needs updating.

regards, tom lane

#5Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#4)
Re: Use <unnamed> for name of unnamed portal's memory context

On 2020-09-05 17:10, Tom Lane wrote:

Julien Rouhaud <rjuju123@gmail.com> writes:

+1 too, and obviously patch looks good.

The adjacent comment needs updating.

committed with that change

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services