[doc] minor wording improvement in a couple of places
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t42909psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 01:05 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t42909_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t42909_1 && git checkout t42909_1Patchset v1 (message #1) is on t42909_1
Hi
On these pages:
https://www.postgresql.org/docs/current/fdw-callbacks.html
https://www.postgresql.org/docs/current/tablesample-method.html
we have the phrase:
"..., which see for additional details."
which strikes me as a bit odd. Suggested phrasing:
"...; see this file for additional details."
Regards
Ian Barwick
--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On Mon, Sep 7, 2020 at 6:34 AM Ian Barwick <ian.barwick@2ndquadrant.com>
wrote:
Hi
On these pages:
https://www.postgresql.org/docs/current/fdw-callbacks.html
https://www.postgresql.org/docs/current/tablesample-method.htmlwe have the phrase:
"..., which see for additional details."
which strikes me as a bit odd. Suggested phrasing:
"...; see this file for additional details."
I agree this sounds very weird. However, this phrasing is also fairly
common in comments around the code.
I was first guessing that this came out of one of us non-english native
speakers, but AFAICT it's a mix of authors and definitely including those
natively speaking the language.
I would still suggest that we change it, because it does sound odd to me as
well, but I'll defer a bit and see if others might think we should keep it.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Mon, Sep 7, 2020 at 6:30 AM Magnus Hagander <magnus@hagander.net> wrote:
On Mon, Sep 7, 2020 at 6:34 AM Ian Barwick <ian.barwick@2ndquadrant.com> wrote:
"..., which see for additional details."
which strikes me as a bit odd. Suggested phrasing:
"...; see this file for additional details."
I agree this sounds very weird. However, this phrasing is also fairly common in comments around the code.
Seems to be a literal translation of Latin "quod vide" (q.v.), so
intentional, just sounds a bit old fashioned. I'd vote to keep it.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services