Sep 2020

1 commit
Avoid useless allocations for information of dumpable objects in pg_dump/
14 Sep 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #13 of 3 reviewers saw the final version

The commit preserves the single three-line addition from #1 in src/bin/pg_dump/common.c, changing numObjs == 0 to numObjs <= 0. This adds the negative-count case proposed by Ranier in #3 and accepted by Michael in #4.

  • Julien Rouhaudsaw the final versiontrailerAfter initially agreeing, Julien confirmed checking the existing count handling and endorsed the final negative-count guard in #5.
  • Ranier Vilelasaw the final versiontrailerRanier reviewed the signed numObjs parameter and supplied the exact <= 0 guard adopted in the commit in #3.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Daniel Gustafsson1
Reviewer
Julien Rouhaud1
Michael Paquiercommitter1
Ranier Vilela1
Committer
Michael Paquier1