Standardize the printf format for st_size

Started by Peter Eisentrautabout 6 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t42945
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 06:38 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t42945_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t42945_1 && git checkout t42945_1

Patchset v1 (message #1) is on t42945_1

Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Existing code uses various inconsistent ways to printf struct stat's
st_size member. The type of that is off_t, which is in most cases a
signed 64-bit integer, so use the long long int format for it.

I don't think anything is affected by this in practice, but it seems
reasonable to set a good convention for the next time this code gets copied.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

t42945_1
0001-Standardize-the-printf-format-for-st_size.patchtext/plain; charset=UTF-8; name=0001-Standardize-the-printf-format-for-st_size.patch; x-mac-creator=0; x-mac-type=0Download+18-19