Sep 2020

5 commits
Improve behavior of tsearch_readline(), and remove t_readline().
24 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #91 of 1 reviewer saw the final version

The three-file implementation matches #9; the only substantive textual difference is an expanded comment explaining returned-string ownership and allocation size in src/backend/tsearch/ts_locale.c.

  • Daniel Gustafssonsaw the final versionLLM analysis, 99% sureIn #10, he examined tsearch_readline callers' memory use and confirmed the safety of #9, which subsequently received only comment changes.
Avoid possible dangling-pointer access in tsearch_readline_callback.
23 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.1+5 more
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #8

Extracts the curline ownership fix from #8: duplicate the error-context string and free it on the next read or shutdown. The standalone fix retains t_readline and adds an explicit EOF guard, leaving persistent buffering and API removal for later.

Simplify SortTocFromFile() by removing fixed buffer-size limit.
22 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #31 of 1 reviewer saw the final version

Commits the src/bin/pg_dump/pg_backup_archiver.c portion of #3, changing its loop to pg_get_line_buf and removing the manual reset. This fixes skipped reset paths described in #4, with an additional include-order cleanup.

  • Tom Lanesaw the final versioncommittercommitted the patch
Remove arbitrary line length limit for libpq service files.
22 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #31 of 1 reviewer saw the final version

Commits the src/interfaces/libpq/fe-connect.c portion of #3, retaining its StringInfo parsing and shared cleanup exit. Committer edits replace manual resets with pg_get_line_buf, initialize *group_found to false, and adjust formatting and comments.

  • Tom Lanesaw the final versioncommittercommitted the patch
Rethink API for pg_get_line.c, one more time.
22 Sep 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment implements this helper; #4 explains that review of #3 prompted it. The commit adds pg_get_line_buf in src/common/pg_get_line.c and converts existing initdb, ECPG regression, and pg_regress callers to automatic buffer resetting.

Credits across 5 commits

Author
Daniel GustafssonLLM2
Tom LaneLLM2
Reviewer
Tom Lanecommitter2
Committer
Tom Lane5

N LLM means N of the credits come from LLM analysis, not from commit trailers.