Dec 2020

2 commits
Change SHA2 implementation based on OpenSSL to use EVP digest routines
4 Dec 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: scram-sha-256 authentication broken in FIPS mode
LLM analysis, 100% suremodified before commitlight changesfrom patchset #371 of 2 reviewers saw the final version

Reconstructing #37 against the commit parent finds only comment reflow in basebackup.c and replacement of elog with an ERRCODE_OUT_OF_MEMORY ereport in cryptohash_openssl.c, requested in #38. This December 2020 patch is newer than every submission listed for thread #132148.

  • Daniel Gustafssonsaw the final versiontrailerDaniel tested the initial conversion in #2, reviewed API and ownership details in #26 and #31, then tested #37 and requested the final error-code adjustment in #38.
  • Heikki Linnakangassaw an earlier versiontrailerHeikki proposed replacing the callback mechanism in #20 with built-in resource-owner tracking in #21, before subsequent generic API and ownership-state redesigns.
Move SHA2 routines to a new generic API layer for crypto hashes
2 Dec 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #341 of 1 reviewer saw the final version

Applying the hunks from #34 to the commit parent reproduces all 23 affected file results exactly, including cryptohash.c, cryptohash_openssl.c, sha2_int.h and the adapted callers.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed allocation semantics and header organization in #26 and #28, requested readability improvements in #31, and explicitly reread the final API patch in #35.

Sep 2020

1 commit
Change SHA2 implementation based on OpenSSL to use EVP digest routines
28 Sep 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: scram-sha-256 authentication broken in FIPS mode
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

Matches #1 except for added failure checks around EVP_DigestInit_ex and EVP_DigestUpdate in src/common/sha2_openssl.c, explicitly described in #19. The September 2020 attachment is newer than the historical patches in thread #132148.

  • Daniel Gustafssonsaw an earlier versiontrailerDaniel reported successful SSL tests with and without FIPS in #2, before the two additional failure-handling branches described in #19 were added.

Credits across 3 commits

Author
Michael Paquier3
Alessandro Gherardi1
Reviewer
Daniel Gustafsson3
Heikki Linnakangas1
Committer
Michael Paquier3