A little enhancement for hashdisk testset
Hi,
In (src/test/regress/sql/aggregates.sql)
I found some tables is not dropped at the end of the sqlscript,
It does not hava any problem, but I think it's better to drop the table in time.
Please see the attachment for the patch.
Best regards,
Houzj
Attachments:
0001-enhance-test-for-hashdisk.patchapplication/octet-stream; name=0001-enhance-test-for-hashdisk.patchDownload
From 16f84c9df14b8ef4fea2f1f595ca183c51d4d0ea Mon Sep 17 00:00:00 2001
From: root <root@localhost.localdomain>
Date: Thu, 24 Sep 2020 09:23:47 -0400
Subject: [PATCH] fix test
---
src/test/regress/expected/aggregates.out | 2 ++
src/test/regress/sql/aggregates.sql | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/test/regress/expected/aggregates.out b/src/test/regress/expected/aggregates.out
index 477fd12..3b86922 100644
--- a/src/test/regress/expected/aggregates.out
+++ b/src/test/regress/expected/aggregates.out
@@ -2766,6 +2766,8 @@ set work_mem to default;
----+----+----
(0 rows)
+drop table agg_data_2k;
+drop table agg_data_20k;
drop table agg_group_1;
drop table agg_group_2;
drop table agg_group_3;
diff --git a/src/test/regress/sql/aggregates.sql b/src/test/regress/sql/aggregates.sql
index 54f5cf7..453eed2 100644
--- a/src/test/regress/sql/aggregates.sql
+++ b/src/test/regress/sql/aggregates.sql
@@ -1216,6 +1216,8 @@ set work_mem to default;
union all
(select * from agg_group_4 except select * from agg_hash_4);
+drop table agg_data_2k;
+drop table agg_data_20k;
drop table agg_group_1;
drop table agg_group_2;
drop table agg_group_3;
--
1.8.3.1
On 24 Sep 2020, at 07:45, Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
I found some tables is not dropped at the end of the sqlscript,
It does not hava any problem, but I think it's better to drop the table in time.
There is value in keeping a representative set of objects around after
regression tests, as the database which is left after regression tests run is
used as the input to the pg_regress tests. That being said, I don't think that
was the intention for these relationns in commit 92c58fd94801, but in general
we should avoid cleaning up too much to ensure that we stress pg_upgrade well
enough (there is a delicate balance to keep test runtime short as well of
course).
cheers ./daniel