remove useless returns
Started by Tang, Haiyingover 5 years ago1 messages
Hello
Found two more useless "return;" lines from the following code.
.src/backend/regex/regcomp.c
.src/interfaces/libpq/fe-secure.c
Maybe it's better to remove them together?
Previous discussion:
/messages/by-id/20191128144653.GA27883@alvherre.pgsql
Best Regards,
Tang
------------------------------------------------
唐海英 (とう かいえい)
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
TEL : +86+25-86630566-8336
COINS: 7998-8313
FAX : +86+25-83317685
Mail:tanghy.fnst@cn.fujitsu.com
------------------------------------------------
Attachments:
0001-Remove-useless-return-lines(2).patchapplication/octet-stream; name="0001-Remove-useless-return-lines(2).patch"Download
From aa7bb56dbb2699ab19dfba39bb36896abf88fa91 Mon Sep 17 00:00:00 2001
From: tanghy <tanghy.fnst@cn.fujitsu.com>
Date: Sun, 27 Sep 2020 14:10:45 +0900
Subject: [PATCH] Remove useless "return;" lines
---
src/backend/regex/regcomp.c | 1 -
src/interfaces/libpq/fe-secure.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/backend/regex/regcomp.c b/src/backend/regex/regcomp.c
index 91078dcd80..612aa8fd64 100644
--- a/src/backend/regex/regcomp.c
+++ b/src/backend/regex/regcomp.c
@@ -1789,7 +1789,6 @@ optst(struct vars *v,
* just spends effort traversing the tree and doing nothing. We can do
* nothing with less effort.
*/
- return;
}
/*
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index 3311fd7a5b..a2993f098a 100644
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -440,7 +440,6 @@ PQgetSSLKeyPassHook_OpenSSL(void)
void
PQsetSSLKeyPassHook_OpenSSL(PQsslKeyPassHook_OpenSSL_type hook)
{
- return;
}
int
--
2.27.0.windows.1