Nov 2020

2 commits
Remove INSERT privilege check at table creation of CTAS and matview
21 Nov 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 1 reviewer saw the final version

The commit adopts #23's removal of the ACL_INSERT block and unused relkind variable in src/backend/commands/createas.c, together with its revised CTAS and materialized-view tests. Michael removed explanatory INSERT references from comments and documentation and reorganized or trimmed tests, as confirmed in #24.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Relax INSERT privilege requirement for CTAS and matviews WITH NO DATA
16 Nov 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #131 of 2 reviewers saw the final version

The commit preserves #13's conditional privilege check and bulk-insert handling in createas.c and its privilege documentation. Michael rewrote comments, explicitly initialized bistate to NULL, and reorganized regression tests, including the required regress_ role prefix, as reported in #14.

  • Anastasia Lubennikovasaw an earlier versiontrailerIn #5 she explicitly reviewed #1 and requested tests for WITH NO DATA and subsequent INSERT failures; bulk-insert lifecycle changes were added afterward.
  • Michael Paquiersaw the final versiontrailerHe examined hook implications in #6, identified inconsistent command behavior and requested tests in #9 and #10, reviewed documentation and bulk-insert handling in #12, and confirmed final review and commitment in #14.

Credits across 2 commits

Author
Bharath Rupireddy2
Reviewer
Michael Paquiercommitter2
Anastasia Lubennikova1
Committer
Michael Paquier2