Jul 2021

2 commits
Fix pg_dump for disabled triggers on partitioned tables
16 Jul 2021Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+2 more
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #18

Takes the pg_dump component of the two-patch series in #18, with additional edits to suppress DROP TRIGGER output, supply tgisinternal for older-server queries, and expand dump and pg_upgrade tests. The commit credits Justin Pryzby and Alvaro Herrera as co-authors, consistent with the original submission #13 and Alvaro's acknowledgment in #16.

Preserve firing-on state when cloning row triggers to partitions
16 Jul 2021Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+2 more
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #182 of 2 reviewers saw the final version

Takes the complete cloning component of #18, leaving its pg_dump component for a separate commit. Applying that attachment to the commit parent reproduces trigger.c and both regression-test files exactly, with only whitespace differences in tablecmds.c and trigger.h; the commit message broadens backpatching to PostgreSQL 11.

  • Justin Pryzbysaw the final versionLLM analysis, 86% sureIn #10, he analyzed compatibility with existing trigger states and identified the related pg_dump preservation problem; the cloning implementation subsequently changed only in tests, formatting, and rebasing.
  • Tom Lanesaw the final versionLLM analysis, 83% sureIn #8, he reviewed the behavioral change's interaction with existing catalogs and pg_dump, raising backpatch-compatibility concerns before only light changes to the cloning patch followed.

Oct 2020

1 commit
Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion
20 Oct 2020Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.1+2 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #5

Retains the recursion relocation from #5, but guards ATSimpleRecursion with RELKIND_PARTITIONED_TABLE and adds regression coverage for legacy inheritance and ONLY. Alvaro explains the required guard in #9 and confirms the commit in #11.

Credits across 3 commits

Author
Alvaro Herrera1 LLM2
Reported by
Justin Pryzby1
Co author
Alvaro Herrera1
Justin Pryzby1
Committer
Alvaro Herrera3

N LLM means N of the credits come from LLM analysis, not from commit trailers.