Probably typo in multixact.c

On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:

Hi

In multixact.c I found some comments like the following:

* Similar to AtEOX_MultiXact but for COMMIT PREPARED
* Discard the local MultiXactId cache like in AtEOX_MultiXact

Since there's no function called "AtEOX_MultiXact" in the code,
I think the "AtEOX_MultiXact" may be a typo.

AtEOXact_MultiXact seems to be the right function here.

Yes, that looks like a simple typo to me as well.
AtEOXact_MultiXact() shares portions of the logics in
PostPrepare_MultiXact and multixact_twophase_postcommit.
--
Michael

On Thu, Oct 8, 2020 at 10:26:39AM +0900, Michael Paquier wrote:

On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:

Hi

In multixact.c I found some comments like the following:

* Similar to AtEOX_MultiXact but for COMMIT PREPARED
* Discard the local MultiXactId cache like in AtEOX_MultiXact

Since there's no function called "AtEOX_MultiXact" in the code,
I think the "AtEOX_MultiXact" may be a typo.

AtEOXact_MultiXact seems to be the right function here.

Yes, that looks like a simple typo to me as well.
AtEOXact_MultiXact() shares portions of the logics in
PostPrepare_MultiXact and multixact_twophase_postcommit.

FYI, this patch was applied.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee