Probably typo in multixact.c
Hi
In multixact.c I found some comments like the following:
* Similar to AtEOX_MultiXact but for COMMIT PREPARED
* Discard the local MultiXactId cache like in AtEOX_MultiXact
Since there's no function called "AtEOX_MultiXact" in the code,
I think the "AtEOX_MultiXact" may be a typo.
AtEOXact_MultiXact seems to be the right function here.
Best regards,
houzj
Attachments:
0001-fix-typo.patchapplication/octet-stream; name=0001-fix-typo.patchDownload
From f51db1bd7a5e533cc71c7d14548f84beabd25347 Mon Sep 17 00:00:00 2001
From: sherlockcpp <sherlockcpp@foxmail.com>
Date: Thu, 8 Oct 2020 09:06:02 +0800
Subject: [PATCH] fix typo
---
src/backend/access/transam/multixact.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index a2ce617..509119e 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -1742,7 +1742,7 @@ PostPrepare_MultiXact(TransactionId xid)
OldestVisibleMXactId[MyBackendId] = InvalidMultiXactId;
/*
- * Discard the local MultiXactId cache like in AtEOX_MultiXact
+ * Discard the local MultiXactId cache like in AtEOXact_MultiXact
*/
MXactContext = NULL;
dlist_init(&MXactCache);
@@ -1772,7 +1772,7 @@ multixact_twophase_recover(TransactionId xid, uint16 info,
/*
* multixact_twophase_postcommit
- * Similar to AtEOX_MultiXact but for COMMIT PREPARED
+ * Similar to AtEOXact_MultiXact but for COMMIT PREPARED
*/
void
multixact_twophase_postcommit(TransactionId xid, uint16 info,
--
1.8.3.1
On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:
Hi
In multixact.c I found some comments like the following:
* Similar to AtEOX_MultiXact but for COMMIT PREPARED
* Discard the local MultiXactId cache like in AtEOX_MultiXactSince there's no function called "AtEOX_MultiXact" in the code,
I think the "AtEOX_MultiXact" may be a typo.AtEOXact_MultiXact seems to be the right function here.
Yes, that looks like a simple typo to me as well.
AtEOXact_MultiXact() shares portions of the logics in
PostPrepare_MultiXact and multixact_twophase_postcommit.
--
Michael
On Thu, Oct 8, 2020 at 10:26:39AM +0900, Michael Paquier wrote:
On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:
Hi
In multixact.c I found some comments like the following:
* Similar to AtEOX_MultiXact but for COMMIT PREPARED
* Discard the local MultiXactId cache like in AtEOX_MultiXactSince there's no function called "AtEOX_MultiXact" in the code,
I think the "AtEOX_MultiXact" may be a typo.AtEOXact_MultiXact seems to be the right function here.
Yes, that looks like a simple typo to me as well.
AtEOXact_MultiXact() shares portions of the logics in
PostPrepare_MultiXact and multixact_twophase_postcommit.
FYI, this patch was applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee